Use uppercase `ID` in `WP_User` based objects to prevent deprecated notices. See #5979.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9116 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Unit Tests, Groups: update the Group factory to handle `false` return values from `groups_create_group`.

It currently assumes that the group is always succesfully created, and this isn't true if `creator_id` is set to `0` (or if there is no logged in user).

See #5983

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9117 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Unit Tests, Groups: test group creation for authenticated vs anonymous user.

These will fail until I get a subsequent commit in; I wanted these in first so we can easily see if the fix works as expected.

See #5983

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9118 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Core: partial revert of r9116 (user->id to user->ID changes).

In our legacy user fetching functions, we use something similar to "select ... ID as id" in the SQL. In the reverted changes, we are only using the property to return an array of integers, and the change of the property name was causing PHP to throw "undefined property" messages.

As these lines would have never thrown a WordPress core deprecated warning about using `id` instead of `ID`, I'm changing them back to clear the warning message and fix the unit tests.

See #5979

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9119 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Unit Tests, Groups: update the group factory to set the group's `creator_id` if one was not passed to the factory.

This is a quicker way of updating hundreds of unit tests where we've previously had a bug that was creating Groups without a valid group creator being set. See #5983 for related changes.

A few tests are counting the number of users in specific circumstances, so those eight tests have been individually updated so that they pass a valid `creator_id` without us having to refactor the entire test.

The `test_group_has_no_members` test has also been removed as it is impossible for a group to have no members. This test used to work because of this bug.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9120 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Groups, Unit Tests: a `creator_id` must be passed to `groups_create_group` to create a group.

Some of our unit tests were built to assume that they would always run with an authenticated user, but obviously this was incorrect. As a result, Groups were being created with `creator_id=0`, which was breaking other parts of the codebase, for certain tests.

This change also removes the `test_creating_new_group_as_anonymous_user` test that I added in r9118 which is now unnecessary.

See r9117, r9118, r9120 for other parts of this fix.
Fixes #5983 and the unit tests. :)

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9121 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Partial revert of r9116 (user->id to user->ID changes)

Has potential for breakage in themes, and requires more investigation before fully addressing.

See #5979.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9122 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Use `bp_update_user_meta()` in `bp_update_user_last_activity()` to ensure `bp_get_user_meta_key` filter is ran.

Fixes bug causing `last_activity` meta to not be prefixed, and includes testcase.

Fixes #5988.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9123 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Simplify default argument parsing in `bp_core_fetch_avatar()`.

* Refrain from setting a couple of unnecessary variables.
* Remove comments, which are redundant with the docblock.

Props dcavins.
See #5958.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9124 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Don't `extract()` in `bp_core_fetch_avatar()`, and pass params to 'bp_core_fetch_avatar_no_grav' hook.

Passing the modified parameters to the hook required moving away from the use
of `extract()`. See #5698.

Props dcavins.
Fixes #5958.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9125 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Add Slack integration key to .travis.yml.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9126 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Improve the way Group's Manage tabs are generated

In {{{BP_Group_Extension->setup_edit_hooks()}}} method, we are now using the {{{bp_core_new_subnav_item()}}} function to generate the Group's manage tab sub navigation.
The action {{{'groups_admin_tabs'}}} is no more used. However for back compatibility reasons, we will keep on catching this hook inviting the user using a {{{_doing_it_wrong}}} message to now use the BuddyPress Group Extension API instead.

props boonebgorges

Fixes #5994

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9127 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Don't show Settings > Email tab when there's nothing to display there.

Props Mamaduka.
Fixes #5441.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9128 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Use a unique variable name in activate heartbeat JS.

The name 'firstrow' was colliding with the "What's new" JS.

Props andemann.
Fixes #6003.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9129 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Pass current group ID to `BP_Group_Extension::display()`.

This creates greater parity with the other display methods in the class.

Props fahmiadib.
Fixes #5533.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9130 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Improve Group's Edit WP Admin Bar menu

Use the group's manage options nav to populate the different edit links of the group's Edit WP Admin Bar.
Introduce a new parameter {{{show_in_admin_bar}}} for the edit screen property of the Group Extension API to allow plugins add their edit link into this Admin Bar (if this parameter is set to true).

props boonebgorges

Fixes #6002

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9131 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Add bulk management for notifications.

Props colabsadmin, lakrisgubben.
Fixes #5513.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9132 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Remove duplicate 'bp_get_activity_show_filters' filter.

'bp_get_activity_show_filters_options' now filters the options used to build
the options markup, while 'bp_get_activity_show_filters' filters the markup.

See #5938.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9133 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Add hook documentation to bp-activity-notifications.php.

See #5938.
Props tw2113.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9134 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Add hook documentation in bp-activity-functions.php.

Props tw2113.
See #5938.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9135 cdf35c40-ae34-48e0-9cc9-0c9da1808c22