Cc pdlogs 61

Updated after review comments for the ENT feature.  
Modified the messages to capitalize acronyms.  
Removed unnecessary whitespace.  
Added full stop to end of each part of the message.  
Actions are numbered if there is more than one action.  This separates the individual actions.
Separated the log definitions with a blank line to make them more readable.  
Ran astyle (according to the coding standards) against sprout_ent_definitions.h.
Fixed header file inconsistencies.
The review comment had: "A lot of the logs still say 'report issue to support' or something similar. This just isn't suitable for Project Clearwater."
The language was kept the same as this is what is done for the SNMP alarm definitions.  The associated documentation should identify the Metaswitch support team for ClearwaterCore and the Clearwater mailing list for Clearwater.
Removed signalnames.cpp.  The signal call name is now obtained from the strsignal call.
Amended the message as,
“Fatal - Must enable P-CSCF, S-CSCF or I-CSCF in /etc/clearwater/config.”
Added the action,
"The P-CSCF is configured by setting the pcscf=<port> option. "

David

From: Eleanor Merry [mailto:notifications@github.com]
Sent: Wednesday, December 17, 2014 10:04 AM
To: Metaswitch/sprout
Cc: David Collins
Subject: Re: [sprout] Cc pdlogs 61 (#895)


In include/sprout_ent_definitions.h<https://github.com/Metaswitch/sprout/pull/895#discussion-diff-21981322>:

> +

> +static const PDLog CL_SPROUT_STARTED

> +(

> +  PDLogBase::CL_SPROUT_ID + 5,

> +  PDLOG_ERR,

> +  "Application started.",

> +  "The application is starting.",

> +  "Normal.",

> +  "None."

> +);

> +

> +static const PDLog CL_SPROUT_NO_SI_CSCF

> +(

> +  PDLogBase::CL_SPROUT_ID + 6,

> +  PDLOG_ERR,

> +  "Fatal - Must enable S-CSCF or I-CSCF in /etc/clearwater/config.",

This isn't right for Bono

—
Reply to this email directly or view it on GitHub<https://github.com/Metaswitch/sprout/pull/895/files#r21981322>.