Client manager hostaddr_str should just be IP address, not port also

The port may not be correct if the client has connected from a different
port either for session trunking or because it dropped the connection and
has created a new connection, so there is no point in printing it out.

hostaddr_str is only ever used in log messages, so this change has no
functional impact.

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Use display_buffer for clientid related string creation

Also, make sure all the related strings are valid when created independently
from a LogXXX macro which might cause problems if log level changes in
mid-stream.

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Have clientid hold a gsh_client reference

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Respond to gsh_client_removeclient better depending on reason for failure

Particularly distinguish between not found and busy.

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Remove cid_client_addr

Use the gsh_client for enerything now.

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Add display_sockaddr function using display_buffer

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Convert rest of SAL display functions to use display_buffer

Also assure that if a string is constructed inside an if (isDebug())
construct, that we keep track of the validity of the string so that if the
log level increases, we don't then print garbage because the string
construction was skipped earlier.

Also, most places where a pointer to a SAL type is printed with %p,
display the referenced object instead.

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Remove redundant test for STATE_TYPE_SHARE in open4_do_open

When we looked for a state with the same owner, we only considered states
of type STATE_TYPE_SHARE so it is redundant to later test if the file_state
which was found is of type STATE_TYPE_SHARE.

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>