Fixing neutron::server deprecated warnings

Clearing default values for deprecated reconnect_interval,
sql_idle_timeout, and sql_max_retries parameters.

Change-Id: I4b34e47dc9a814c0fbcc0fd6d8fe6033081a51d0
Closes-Bug: #1269623
(cherry picked from commit b14cee10c155c30dbf7b1645dfa095c4d5b0aa73)
Merge "Fixing neutron::server deprecated warnings" into stable/havana
Revert "Fixing neutron::server deprecated warnings"

This reverts commit b799640d219b42955165bd81acde5b32ee0f99f9.

Change-Id: I978cd75b8264e1b5234fc930d4488fff513fe53e
Fixing neutron::server connection parameter

Previously, neutron::server's (deprecated) sql_connection parameter
had a default value, preventing the new/preferred connection
parameter from ever being used.

This change removes that default, permitting the connection
parameter to work properly, and extends unit tests to confirm.

bug introduced at commit 82552e79316a4ffc1c879dd3aaa1f4735a4a35a0,
change I300fc12092bca1abdd105e0c0c272f7fd49258ac

Change-Id: I116b482c620b5c44b88c1b801438a100343f6f9f
(cherry picked from commit af1fd0b6042c76fc48bae81d36a74b7a51d00fb7)
Tune up report and downtime intervals for l2 agent

If the neutron server erroneously thinks than the l2 agent is down
it will fail to bind a port, which can lead to VM's spawn errors.

This patch aims to add support for agent checks flags.

Change-Id: If047c5d52d10a8ca9b1b765400bdd99a29550b1e
Signed-off-by: Emilien Macchi <emilien.macchi@enovance.com>
(cherry picked from commit 30885efc1f7ee1b8490474399014f1f5c931097f)
Remove check for correct core_plugin when using ml2.

This checks fails, because $::neutron::core_plugin
is not available in the context of ml2.pp.

Change-Id: I96c11c5a57c530f72e0e71447831b8219c12a685
(cherry picked from commit 2cc78fb7850c913afb5e79aa0eef24f7f6a92ba0)
Add support for neutron nvp plugin

This patch adds support for NVP plugin configuration.

implement blueprint nvp-plugin-support
Change-Id: I8aff4fc6895ed5a3342e2e93d306014ec0982af8
(cherry picked from commit 25abac3c93442898203a42526cb4fb3d41fa140d)
ensure linuxbridge dependency is installed on RHEL

Package['neutron-plugin-linuxbridge'] is defined in
plugins/linuxbridge.pp but is missing in agents/linuxbridge.pp.

If agents::linuxbridge is used directly, the package is not defined.
This changes fixes the situation on RHEL.

The problem has already been fixed for OVS in
changeset Iedf8a607915f65b7a8cf7af99749b9b65cba7bd9

Change-Id: Ic4e15825e4f2d1f2ce2c34d2fdb01c8f6b19d491
(cherry picked from commit
9bb97fd444f28f797fc500331e9c52b660680e07)
Merge "Revert "Fixing neutron::server deprecated warnings"" into stable/havana
Merge "Fixing neutron::server connection parameter" into stable/havana
Merge "Tune up report and downtime intervals for l2 agent" into stable/havana
L3 schedulers support

Icehouse brings new schedulers for virtual routing.
This patch aims to:
- add router_scheduler_driver flag support
- document which schedulers we could use

Cherry-pick notes:
  - Removed neutron.scheduler.l3_agent_scheduler.LeastRoutersScheduler
    from puppetdoc. It is not available in Havana.

Change-Id: I9ed4464201e1b888ae7474221babe8e5aad38642
Signed-off-by: Emilien Macchi <emilien.macchi@enovance.com>
(cherry picked from commit a57669a9dc3bacb80011ac45cf3da743de68e0bd)
Fixing neutron::server deprecated warnings

Clearing default values for deprecated reconnect_interval,
sql_idle_timeout, and sql_max_retries parameters.

Original Change-Id: I4b34e47dc9a814c0fbcc0fd6d8fe6033081a51d0
Closes-Bug: #1269623
(cherry picked from commit b14cee10c155c30dbf7b1645dfa095c4d5b0aa73)

Change-Id: Ib9ffc58fcb49c2c370950a1199878427e5a9efdb
Using contain_class instead of include_class

Per rspec-puppet-1.0.1 warning:

DEPRECATION: include_class is deprecated. Use contain_class instead.
Called from .../vendor/gems/rspec-puppet-1.0.1/lib/rspec-puppet/
matchers/include_class.rb:7

Change-Id: I6bc63343597f1b574f9da5beaae187dcc2b3485d
(cherry picked from commit 691e8d755201800707ac4f0c188696b3143f5020)
Havana: Fixtures: fix keystone branch name

Solve issue: « fatal: ambiguous argument 'stable/havana': unknown
revision or path not in the working tree. »

Change-Id: I1752c19bfd18b26ea0ad4ad0b8d464c5a86b7261
Fix improper test for tunnel_types param

When VXLAN support was added to the ovs agent manifest, a new
parameter called tunnel_types was also added with the default
value being an empty array.  However, later in the code there's
an if loop that tests truth--and an empty array returns true.
This causes a line of the form:

tunnel_types =

to show up in /etc/neutron/plugins/openvswitch/ovs_neutron_plugin.ini
if the default value is used, which causes OVS to refuse to start.
This patch corrects the problem by properly testing the array.

Change-Id: I06ad6249ab7803676e49c026b4692f06ade269ed
Closes-Bug: #1281684
(cherry picked from commit f3a4b53a417db64ed7c26980893a4a8e3ccde83c)
Merge "L3 schedulers support" into stable/havana
Merge "Fixing neutron::server deprecated warnings" into stable/havana
Merge "Havana: Fixtures: fix keystone branch name" into stable/havana
Allow log_dir to be set to false in order to disable file logging

This commit allows a user to disable logging to a directory (for
example if syslog is enabled) in order not to login twice.

Conflicts: spec/classes/neutron_server_spec.rb

(cherry picked from commit 2efcff08d3aac7dcca9a6e1fa228a63db36de06e)
Change-Id: I0d201b8892cdaea86714b39f7716e763a40a2adc
Closes-bug: #1282296