Simplify and rename helper method

The new name better reflect what the method is returning. It was also
over-complicated. Firstly it had a boolean flag switching whether it
returned a link or just plain text, but there is nowhere in the app that
uses it to generate a link. Also a `current?` role appointment will
never have an ended_at timestamp, so the ternary operator check is
redundant.