Should not validate G, G' for cases when it is nan

Ok, maybe it can be kept as unusual, but it will throw the warnings in
table.py and other similar scripts. If it gets put back, can the warning
also include the mineral name and formula? Actually, in general maybe we
should put the name in for all the warnings?
On 14 Dec 2014 23:13, "Ian Rose" <notifications@github.com> wrote:

> In burnman/eos/slb.py
> <https://github.com/geodynamics/burnman/pull/91#discussion-diff-21808398>:
>
> > @@ -289,7 +291,7 @@ def validate_parameters(self, params):
> >              warnings.warn( 'Unusual value for Gprime_0', stacklevel=2 )
> >          if params['molar_mass'] < 0.001 or params['molar_mass'] > 10.:
> >              warnings.warn( 'Unusual value for molar_mass', stacklevel=2 )
> > -        if params['n'] < 1. or params['n'] > 1000.:
> > +        if params['n'] < 1. or params['n'] > 1000. or float(params['n']).is_integer() == False:
>
> Hmm, I mean, it does not have to be, mathematically. Should we warn people
> if it is not, though? I would think that it is still "unusual", in the
> words of the warning.
> … <#14a4ccb225a31435_>
> On Sun, Dec 14, 2014 at 11:07 PM, Timo Heister <notifications@github.com>
> wrote: In burnman/eos/slb.py <
> https://github.com/geodynamics/burnman/pull/91#discussion-diff-21808303>:
> > @@ -289,7 +291,7 @@ def validate_parameters(self, params): >
> warnings.warn( 'Unusual value for Gprime_0', stacklevel=2 ) > if
> params['molar_mass'] < 0.001 or params['molar_mass'] > 10.: >
> warnings.warn( 'Unusual value for molar_mass', stacklevel=2 ) > - if
> params['n'] < 1. or params['n'] > 1000.: > + if params['n'] < 1. or
> params['n'] > 1000. or float(params['n']).is_integer() == False: this is
> where he removed the integer check... @bobmyhill
> <https://github.com/bobmyhill> <https://github.com/bobmyhill> ? — Reply
> to this email directly or view it on GitHub <
> https://github.com/geodynamics/burnman/pull/91/files#r21808303>.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/geodynamics/burnman/pull/91/files#r21808398>.
>