updating attributes working now