the gemspec locks us to faye-websocket 0.7.0


On Fri, Feb 14, 2014 at 10:24 AM, Tony Spataro <notifications@github.com>wrote:

> In lib/right_agent/clients/router_client.rb:
>
> > @@ -23,6 +23,19 @@
> >
> >  require 'faye/websocket'
> >
> > +# Monkey patch WebSocket close method so that can specify status code and reason
> > +# Valid status codes are defined in RFC6455 section 7.4.1
> > +module Faye
>
> We should open a pull request to contribute this upstream, and in the
> right_agent gemspec, we might want to lock ourselves to a specific version
> of the websocket gem to guarantee that our monkey patch doesn't break in
> hard-to-debug ways.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/rightscale/right_agent/pull/104/files#r9758111>
> .
>