Add _total suffix to counter metrics

Update metrics to match conventions expected by prometheus #86

@juliusv @jmyounker 
I second Julius's comments about
container_(create|destroy|start|stop)_total.

container_status_(.*)_total can remain unchanged.


On Thu, Oct 16, 2014 at 12:06 PM, juliusv <notifications@github.com> wrote:

> In harpoon-agent/instrumentation.go:
>
> > @@ -21,21 +21,21 @@ import (
> >  //   - delivered count + undelivered count = deliverable
> >  //
> >  var (
> > -	expvarLogReceivedLines                   = expvar.NewInt("log_received_lines")
> > -	expvarLogUnparsableLines                 = expvar.NewInt("log_unparsable_lines")
> > -	expvarLogUnroutableLines                 = expvar.NewInt("log_unroutable_lines")
> > -	expvarLogDeliverableLines                = expvar.NewInt("log_deliverable_lines")
> > -	expvarLogUndeliveredLines                = expvar.NewInt("log_undelivered_lines")
> > -	expvarContainerCreate                    = expvar.NewInt("container_create")
> > -	expvarContainerCreateFailure             = expvar.NewInt("container_create_failure")
> > +	expvarLogReceivedLines                   = expvar.NewInt("log_received_lines_total")
> > +	expvarLogUnparsableLines                 = expvar.NewInt("log_unparsable_lines_total")
> > +	expvarLogUnroutableLines                 = expvar.NewInt("log_unroutable_lines_total")
> > +	expvarLogDeliverableLines                = expvar.NewInt("log_deliverable_lines_total")
> > +	expvarLogUndeliveredLines                = expvar.NewInt("log_undelivered_lines_total")
> > +	expvarContainerCreate                    = expvar.NewInt("container_create_total")
>
> This and some others aren't really English plurals, although the meaning
> of the metric is. Maybe agree with the harpoonites on the best terms here,
> but some suggestions:
>
> container_create_total -> container_creates_total or
> container_create_events_total
> container_destroy_total -> analogous to above
> container_start_total -> analogous to above
> container_stop_total -> analogous to above
>
> Not sure about how to do that best for these:
> container_status_kill_total
> container_status_down_successful_total
> container_status_force_down_successful_total
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/soundcloud/harpoon/pull/96/files#r18947182>.
>



-- 
- Jeff Younker - jmy@soundcloud.com - +49 (0) 171 5641365 -