Lacosmicx

I have finished the optimized LA Cosmic implementation. It uses Cython for the main part of the algorithm and uses C for the individual routines. Everything is multithreaded using OpenMP (the Cython standard). For a 4K x 2K image, this implementation is ~35 times faster than cosmics.py written by Malte Tewes (which is already significantly faster than the original IRAF version). 

Given the complexity of this code, should this be included in imageutils or should it be its own package? 

Any other comments are welcome.
Hi Christoph and Larry,
I think you want user cmccully, not cmcully (one fewer c). :-)

________________________________
From: Christoph Deil [notifications@github.com]
Sent: 12 November 2014 14:09
To: astropy/imageutils
Cc: Christopher Cully
Subject: Re: [imageutils] Lacosmicx (#35)


In imageutils/lacosmicx/laxutils.c:

> +         * the correct position */
> +        ELEM_SWAP(arr[low], arr[hh]);
> +
> +        /* Re-set active partition */
> +        if (hh <= median)
> +            low = ll;
> +        if (hh >= median)
> +            high = hh - 1;
> +    }
> +
> +}
> +
> +#undef ELEM_SWAP
> +
> +/* All of the optimized median methods below were written by
> + * Nicolas Devillard and are in the public domain.


Is it OK to copy public domain code and put it under BSD in Astropy?
http://programmers.stackexchange.com/questions/76148/what-is-the-difference-between-releasing-code-under-the-bsd-license-and-releasin

If it's not 100% clear maybe we can get Nicolas Devillard to comment on this PR that he gives us permission to do this?

—
Reply to this email directly or view it on GitHub<https://github.com/astropy/imageutils/pull/35/files#r20251544>.