Small refactoring of AudioProcessing use in channel.cc.

- Apply consistent naming.
- Use a scoped_ptr for rx_audioproc_.
- Remove now unnecessary AudioProcessing::Destroy().

R=bjornv@webrtc.org, xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2184007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4784 4adac7df-926f-26a2-2b94-8c16560cd09d
Compile ACM2 and ACM1.

First patch set is the same as patch set 3 of http://review.webrtc.org/2237004/

-Make ACM1 to depend on ACM2.
-Remove APIs to set and get background noise mode. There is no VoE call to these
APIs.
-Remove APIs to set and get receive side VAD mode. There is no VoE call to these
APIs, and NetEq 4, doesn't support them.
-Remove callback for in-band DTMF detection. ACM doesn't support in-band DTMF
detection.
-Use acm_common_defs.h everywhere required.
-Complete ACM factory method.
-Update ACMCodecDatabase of ACM2. CNG full-band need to be define-guarded.
Remove dynamic payload-type assignment.

BUG=
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2249004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4785 4adac7df-926f-26a2-2b94-8c16560cd09d
Update talk to 52534915.

R=sergeyu@chromium.org

Review URL: https://webrtc-codereview.appspot.com/2251004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4786 4adac7df-926f-26a2-2b94-8c16560cd09d
Disable tests for TSan v2

These are tests that fail and that I haven't been able to suppress.
I assume they're caused by the same bug in TSan v2 as described in
webrtc:2259.

BUG=2259,2334
TEST=Ran the tests similar to the instructions in the bugs, passed 100 iterations.
R=andrew@webrtc.org, hta@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2250004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4787 4adac7df-926f-26a2-2b94-8c16560cd09d
Fixes a flake in network down tests.

And reduces the flakiness in NACK tests.

TESTS=trybots
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2258004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4788 4adac7df-926f-26a2-2b94-8c16560cd09d
Disable NACK bandwidth statistics test due to being too flaky.

Tests for new API currently provide partial coverage, and will soon
provide full coverage.

TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2151005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4789 4adac7df-926f-26a2-2b94-8c16560cd09d
Refactor frame generation code so it can be used by multiple modules.

R=pbos@webrtc.org, stefan@webrtc.org, pbos, stefan
BUG=

Review URL: https://webrtc-codereview.appspot.com/2240004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4791 4adac7df-926f-26a2-2b94-8c16560cd09d
Heap-use-after-free in WebRtcNetEQ_RecInRTPStruct

Pointer to released memory was not set to NULL, which means
you could get a heap-us-after-free in the code. It happens if one of the slaves of NetEq is deleted, but we keep trying to decode packets.

BUG=
R=henrik.lundin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2259004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4792 4adac7df-926f-26a2-2b94-8c16560cd09d
Rename EngineTest to CallTest.

There's no real notion of VideoEngine left in these classes. They're
end-to-end tests built on Call, so CallTest makes more sense.

This also contains a modification to RtpRtcpObserver moving the
responsibility of creating the event that signals when the observation
is complete to RtpRtcpObserver. New tests are about to be introduced and
this will reduce code duplication.

BUG=
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2258005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4793 4adac7df-926f-26a2-2b94-8c16560cd09d
Roll webrtc's chromium_revision 217707:224141

Also adds -lm for executables depending on isac since the newer clang in the
newer chromium revision requires it, and -lstdc++ for dependencies of the objc lib because newer gyp links with gcc instead of g++ for non-C++-containing libs.

R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2177007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4795 4adac7df-926f-26a2-2b94-8c16560cd09d
Use link_settings instead of all_dependent_settings to pacify xcode gyp generator

Should unbreak e.g. http://chromegw/i/chromium.webrtc.fyi/builders/Mac%20%5Blatest%20WebRTC%20trunk%5D/builds/2396

R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2261004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4796 4adac7df-926f-26a2-2b94-8c16560cd09d
Suppress SSL error strings on mac_asan to unbreak that build
Example borkedness: http://chromegw/i/client.webrtc/builders/Mac%20Asan/builds/642/steps/libjingle_p2p_unittest/logs/stdio

R=marpan@google.com

Review URL: https://webrtc-codereview.appspot.com/2263004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4798 4adac7df-926f-26a2-2b94-8c16560cd09d
Removing the tsan text exclusion since the tests should be passing now.
BUG=2299, 2290, 2291
R=wu@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2260004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4799 4adac7df-926f-26a2-2b94-8c16560cd09d
Avoid recursively taking critical section.

TEST=trybots
BUG=2261
R=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2258006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4800 4adac7df-926f-26a2-2b94-8c16560cd09d
Disable flaky video capture test.

BUG=2405
TBR=fischman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2265005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4801 4adac7df-926f-26a2-2b94-8c16560cd09d
Enable FEC for VideoSendStream.

Test only checks for FEC without NACK. Test for FEC with NACK postponed
until later.

BUG=2230
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2246004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4802 4adac7df-926f-26a2-2b94-8c16560cd09d
Address Windows 64-bits warnings.

R=henrik.lundin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2203004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4803 4adac7df-926f-26a2-2b94-8c16560cd09d
VAD changes ported to ACM2.

This CL ports the relevant parts of  https://code.google.com/p/webrtc/source/detail?r=4625 to ACM2.

BUG=
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2264004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4804 4adac7df-926f-26a2-2b94-8c16560cd09d
Made sure that DTLS/SRTP is set to false in apprtc demo when testing loopback. See crbug/294881 for details.

R=juberti@google.com, mallinath@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2268004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4805 4adac7df-926f-26a2-2b94-8c16560cd09d
Fix bugs in DesktopRegion::Subtract().

Fixed a bug that caused the crash in the linked bug and also couple of
other issues in the same code. Also added more tests.

BUG=crbug.com/295057
R=wez@chromium.org

Review URL: https://webrtc-codereview.appspot.com/2259005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4806 4adac7df-926f-26a2-2b94-8c16560cd09d