don't log errors when all is fine
Small Action View Overview edits [ci skip]

Some small grammar and readability edits
Define the Duration#instance_of? method

Since Duration is extending from ProxyObject which extends itself from
BasicObject, the Duration object doesn't respond to the #instance_of?
method. Thus, the #method_missing hook get triggered, delegating the
method to its `value` attribute.

However, Rubinius' #eql? definition relies on #instance_of?, thus this
will equal to true with a Fixnum (since its `value` attribute is a
Fixnum) while it should not.

The previous behavior was wrong anyway, no matter the implementation.
Grammar pass

[ci skip]

Add improvements from @eileencodes [skip ci]
Only merge scopes with zero arity in has_many through

with dynamic conditions.

Fixes #16128

This bug was introduced in https://github.com/rails/rails/commit/c35e438620f2d56562251571377995359546393d
so it's present from 4.1.2-rc1 and after.

https://github.com/rails/rails/commit/c35e438620f2d56562251571377995359546393d
merges any relation scopes passed as proc objects to the relation,
but does *not* take into account the arity of the lambda.

To reproduce: https://gist.github.com/Agis-/5f1f0d664d2cd08dfb9b
[ci skip] "..enables interrorgating of [thing].." would be correct
Move as/test_test to as/test_case_test
Add documentation intro to example for `Object#itself`.

Also moved comment for removal above `unless()` to not confuse RDoc with
the documentation for this method.
Updated the deprecation warnings to 5.0
Ignore Postgresql "SELECT tablename FROM pg_tables" when counting queries
remove end-of-line spacing in development.rb, production.rb
Merge pull request #16579 from nsinenko/master

Remove end-of-line spacing in development.rb, production.rb
Clear deliveries in order not to affect other tests
Merge pull request #16577 from cristianbica/update-deprecation-to-5.0

Updated the deprecation warnings to 5.0
Revert "Do not gsub non ASCII characters in header anchor.".

This reverts commit 699babe.

Also change the upgrading_ruby_on_rails link back to original in 4_2_release_notes.
Merge pull request #16581 from JuanitoFatas/guides-anchor-link

Revert "Do not gsub non ASCII characters in header anchor.".
Merge pull request #16573 from zzak/test_test_to_test_case_test

Move as/test_test to as/test_case_test
[ci skip] Format pass of Active Job Basics guide.
Merge pull request #16145 from phoet/patch-2

don't log errors when all is fine
Fixes the digits counter of AS's NumberToRoundedConverter

Zero has one digit, but Math.log10(0) returns -Infinity. The method
needs to special-case zero.

The patch adds a regression test that is not clearly related to the
underlying issue because digit_count is private and has no coverage.
Gray area.

This bug was uncovered by 60062cf.