Well this is why private members is *always* better. There is a trade
off... Keeping the field name allows the data file to preserve downgrade
compatibility at the expense of loss of binary compat.

If we switch to a different field, then they will need a readResolve method
and the hpi-plugin `compatibleSinceVersion` should be set to flag the fact
that people cannot downgrade without loss of config (which gives the big
red scary warning)

On Saturday, 24 May 2014, ikedam <notifications@github.com> wrote:

> In
> src/main/java/hudson/plugins/build_timeout/impl/AbsoluteTimeOutStrategy.java:
>
> >  /**
> >   * If the build took longer than <tt>timeoutMinutes</tt> amount of minutes, it will be terminated.
> >   */
> >  public class AbsoluteTimeOutStrategy extends BuildTimeOutStrategy {
> >
> > -    public final int timeoutMinutes;
> > +    public final String timeoutMinutes;
>
> Hmm... public members prevent us from preserving binary compatibility.
> Is it safer to create a new member (like timeoutMinutesString) and leave
> old field with deprecated annotation?
>
> Anyway, on this occasion we should make members private and create getters
> for them instead.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jenkinsci/build-timeout-plugin/pull/29/files#r13024881>
> .
>


-- 
Sent from my phone