I’m fine with this. I’ll make the changes  


On Tuesday, March 11, 2014 at 12:26 PM, Lee Jensen wrote:

> In source/home.html:
> > @@ -1,3 +1,14 @@ > +{% if theme.show_slideshow %} > + {% if theme.image_sets.slideshow_images.size > 0 %} > + <div class="flexslider"> > + <ul class="slides"> > + {% for image in theme.image_sets.slideshow_images %}  
> I talked with @joshnabbott (https://github.com/joshnabbott) offline about updating the other image references so they aren't so archaic. For instance instead of
> {{ theme.image }}  
> we would use
> {{ theme.images.logo }}  
> And actually changing the settings. Since we're bumping a minor version and this doesn't have to be backward compatible fixing up those variable names to be more semantic feels appropriate.
> As for the slideshow name I feel like image_sets.slideshow is more consistent with the way the other images will be given that change (e.g. we're not calling them theme.images.logo_image). I feel fairly strongly that we'll be setting an example for theme developers with this theme and I would prefer to drop the _images postfix if you guys don't have strong feelings one way or another.
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/bigcartel-themes/luna/pull/97/files#r10488201).
>  
>  
>