On 30 de Maio de 2014 4:43:18 WEST, Jeff Schroeder <notifications@github.com> wrote:
>> @@ -2053,13 +2053,13 @@ def top_matches(self, top):
>>                      for item in data:
>>                          if isinstance(item, string_types):
>>                              matches[saltenv].append(item)
>> -        ext_matches = self.client.ext_nodes()
>> -        for saltenv in ext_matches:
>> -            if saltenv in matches:
>> -                matches[saltenv] = list(
>> -                   
>set(ext_matches[saltenv]).union(matches[saltenv]))
>> -            else:
>> -                matches[saltenv] = ext_matches[saltenv]
>> +        # ext_matches = self.client.ext_nodes()
>> +        # for saltenv in ext_matches:
>> +        #     if saltenv in matches:
>> +        #         matches[saltenv] = list(
>> +        #            
>set(ext_matches[saltenv]).union(matches[saltenv]))
>> +        #     else:
>> +        #         matches[saltenv] = ext_matches[saltenv]
>
>You should probably remove this code. Committing commented code doesn't
>seem like a great idea.
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/saltstack/salt/pull/13123/files#r13215630

Jeff! I haven't "seen" you for a while now... 
Pedro Algarvio @ Phone