Removed minor dead stores, to fix warnings

Change-Id: I7f24245fcebe8949d8028a15a85254970c42dbd9
Refactor to make intent clear to clang analyzer

It warned that ‘ext’ could be used uninitialized.
It didn’t see that the test after the for loop was testing
if the loop got all the way to the end without breaking.
Added bool instead to be explicit about it.

Change-Id: I006d1b3794e596ee08226b2c3f9167cccc145cc7
Fixed warning about possible null deref

Presumably ‘producer’ can never be null because
it’s unconditionally dereferenced a few lines below
this change.

Change-Id: I85c425ae1eaa17cf56118b90472412bec1c705c9
Fix clang analyzer warning by adding temp variable

With this temporary, it realizes the ?: and switch
branches are really making the same tests.

Change-Id: I14aa9e1612d64197d339048ec6bf3990655ea336
Fixed warning about using ‘volBounds’ uninitialized

It didn’t see that the loop should always be entered
at least once.  The loop was special-casing the
first iteration; pulled that out.

I think this is more readable anyway.

Change-Id: I96492639a267be13f234a5f051dafa6d3997d83e
Merge topic 'analyzer-warnings3' into master

af2526da Fixed warning about using ‘volBounds’ uninitialized
3099508a Fix clang analyzer warning by adding temp variable
92f6a354 Fixed warning about possible null deref
6e773e1d Refactor to make intent clear to clang analyzer
68294b7d Removed minor dead stores, to fix warnings