Issue 27 For some initial review... 

Before I start implementing this all over the place!
Yeah. I fixed that already in my local copy.
Right now it be good to agree on the approach.

On Thursday, October 9, 2014, vfunshteyn <notifications@github.com> wrote:

> In core/src/main/java/org/ehcache/InternalStatus.java:
>
> > +
> > +  public abstract Status toPublicStatus();
> > +
> > +  public class Transition {
> > +
> > +    private final InternalStatus from;
> > +    private final InternalStatus to;
> > +    private final Thread owner = Thread.currentThread();
> > +
> > +    private volatile InternalStatus done;
> > +
> > +    private Transition(final InternalStatus to) {
> > +      if(to == null) {
> > +        throw new NullPointerException();
> > +      }
> > +      this.from = InternalStatus.this;
>
> This from field appears to be redundant, as this is an inner class.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ehcache/ehcache3/pull/106/files#r18681923>.
>


-- 
Alex Snaps <alex.snaps@gmail.com>
Principal Software Engineer - Terracotta
http://twitter.com/alexsnaps
http://about.me/alexsnaps
http://www.devoxx4kids.org/quebec/