Okay, I see where your coming from.  I did a literal fresh install and seen that it does nothing.  The only reason someone would uncheck the box is if their database is not already in utf-8.  So if that was my only mistake in the PR, have you looked at the rest of the modified files yet including the links plugin?

Do you want me to continue onto the next plugin?

Michael


From: Mark R. Evans 
Sent: Sunday, May 11, 2014 8:52 PM
To: glFusion/glfusion 
Cc: Michael Brusletten 
Subject: Re: [glfusion] Changed files to be html5 and utf-8 validated for default theme (#28)

In public_html/siteconfig.php.dist:

> @@ -161,7 +161,7 @@ $_CONF['js_cache_filename'] = 'jscache_';
>  $_CONF['path'] = '/path/to/glfusion/';
>  $_CONF['path_system'] = $_CONF['path'] . 'system/';
>  
> -$_CONF['default_charset'] = 'iso-8859-1';
glFusion is already UTF-8 out of the box - the default install is UTF-8 - but the user has the option to de-select it if they need to. What I think you are not understandnig is that the line in stieconfig.php.dist is meaningless - iso-8859-1 is simply a placeholder that is overwritten during install. There is no value in changing it. But, if you do change it there - you have to update the install program to now look for the new string to do the replacement. When it is all said and done, changing the .dist file does nothing to make a site utf-8 or not.

—
Reply to this email directly or view it on GitHub.