(PUP-2009) Lookup environment from settings in interpolation

Settings#convert() used to have the behavior that if it was
interpolating $environment, and no environment was available to the
method, it would fall through and make another setting lookup for
environment.  This would result in the default or set environment being
obtained.

In 00c2abf of the #23373 command line manipulation of puppet.conf work
which involved a refactor of the setting parsing, this behavior changed,
such that whatever @environment was set in the ChainedValues instance
performing the setting lookup and interpolation, that value would be
returned for $environment, even if nil.

This is the case when asking an actual Setting instance what it's value
is, as it looks it up from settings without supplying an environment,
which results in something like
'manifestdir=/foo/environments/$environment/manifests' interpolating
as '/foo/environments/manifests'.  This can result in the bug seen in
PUP-2009 where a master can fail attempting to manage this typically
non-existent directory because of Settings#use() and to_catalog().

This commit restores the old behavior, allowing interpolation of
$environment to lookup environment from settings when no environment
value was explicitly passed in.
Merge pull request #2462 from jpartlow/issue/stable/pup-2009-manifestdir-dynamic-environments-fails

(PUP-2009) Lookup environment from settings in interpolation
Merge remote-tracking branch 'upstream/stable'

* upstream/stable:
  (PUP-2009) Lookup environment from settings in interpolation
Merge branch 'master' of https://github.com/puppetlabs/puppet