Width given in format string is larger than the destination buffer.
Type mismatch between scanf format specifier (unsigned long long) and the variable type (long long).
str*cpy / strlen performance fix.

Calculating length of a string two times is unnecessary, and using strncpy width known string length can be replaced with memcpy.
Variable type fix for fgetc.

Reading a single character is fine with fgetc. But if you want to check for EOF, then you have to use 'int' as type,
and if the return value is not EOF, then it can be cast to 'char'.

Example for fail scenario before the fix: if the file contains 0xff character, then the code will interpret it as EOF.
0xff can be banned, but this should be checked in a proper way and not in the reading code.
Preventing use-after-freed possibility.

Probably the original intention was to prevent the possibility of a use-after-freed bug.
But the last strs = NULL statement has no effect, because it's just a local copy.
However, it makes sense to put a similar solution inside the loop right after the memory release.
This way if some codes try to use a previously freed array, then the array will seem to be empty.
String lib performance fix: using memcpy when the length is known.

Using strncpy(target, string, strlen(string)) equals with memcpy(target, string, strlen(string).
Both of them remove the \0 from the end. But for longer string memcpy is definitely more efficient,
because it does not have to search for string termination.

Usually the performance difference is small, and this kind of code rarely used elsewhere,
but a string handling lib should be efficient.
Type fix: 'char*' should be used for string storing instead of 'char'.
Fix for an unlikely memory leak in a unit test.

1 or 2 hosts work fine, otherwise the reserved memory should be released.
(However, using not 1 or 2 is quite hypothetical.)
strncpy fixes: wrong buffer size, lack of termination and similar errors are fixed.

There are lot of fixes here, but they are in a few main category:
1, strncpy(target, source, TARGETSIZE-1)  -> strlcpy(target, source, TARGETSIZE)
   If the target's last byte is not \0, then the string will not be terminated.
2, strncpy(target, source, TARGETSIZE) -> strlcpy(target, source, TARGETSIZE)
   If the source is longer than the target, then the string will not get NUL termination
3, combination of memset + strncpy or strncpy + buffer[last_byte]=0 -> strlcpy
   It's ugly and inefficient but at least gives correct result.

Remark: the usual string length (e.g. variable name, path) is much shorter than the buffer size (1k or 4k)
Using strncpy is quite inefficient because it always fills the rest of the array with 0s.
If you definitely need this feature, then rather use a memset + strlcpy + comment.
(E.g. // I want to fill this whole buffer with 0s, because it contained a private key previously.)
strncpy / strncat inefficiencies.

strncpy with known length can be replace with memcpy.
manual \0 + strncat is ugly, and strlcpy just does the job well.
strncpy + manual termination -> strlcpy
A few more strncpy fixes: buffer size limit, termination, etc.
Memory leak fix in 'ConfigurationDestroy'.
Redmine#4913: file_hash function
Redmine #5819: Fix /etc/shadow extra newline between each entry.

getline() includes the newline in the returned string, so switch to
CfReadLine() instead so we don't get a double newline between entries
when we edit /etc/shadow.
Redmine#5655 Force removal of keys and their dependencies in cf-key
Redmine#5655 Fix bug in coherence mode of removal of IPs in cf-key
Merge pull request #1718 from jeffali/force_key_removal

Redmine#5655 Force removal of keys and their dependencies in cf-key
Redmine #5819: Fix failing chpasswd execution on Ubuntu 10.04.

Ubuntu 10.04 chpasswd doesn't support the '-e' option, so check for it
before executing. We reuse the function that checks for '-M' and as
part of this, the cached return value was removed. Slightly less
efficient, but the function is only called if something changes, and
you'd have to modify users in the thousands before it becomes a real
problem.
Merge pull request #1716 from kacfengine/chpasswd_e_fix

Redmine #5819: Users promise fixes for Ubuntu 10.04
Redmine #4241: Depr. INTERRUPTED promise status that was never used.

There was some code for setting classes based on this promise status,
but it was never implemented in the syntax, so it was impossible to
set a class based on it. Since we don't really need to introduce any
more promise outcomes, we alias the INTERRUPTED status to the "failed"
classes attribute.

The actual status is however left intact since it has been available
in reporting.