working on action  handler