Streaming log API now also honors history argument.

This addresses issue #56.

I'm going to beg to differ.  In function calls the name serves as
documentation, and it's necessary to distinguish between the two different
logs arguments.  Those things are historical logs and that's not at all
apparent from just looking at the function signature unless the information
is in the name.



On Fri, Oct 17, 2014 at 4:38 PM, Peter Bourgon <notifications@github.com>
wrote:

> In harpoon-agent/api.go:
>
> >  }
> >
> > -func (a *api) streamLog(logs *containerLog, enc *eventsource.Encoder, stop <-chan bool) {
> > +func (a *api) streamLog(histLogs []string, logs *containerLog, enc *eventsource.Encoder, stop <-chan bool) {
>
> Thanks for the change! The same naming policy for handleLog applies here,
> too, I think.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/soundcloud/harpoon/pull/92/files#r19021075>.
>



-- 
- Jeff Younker - jmy@soundcloud.com - +49 (0) 171 5641365 -