[Cocoa] WKNavigationResponsePrivate.h is internal
https://bugs.webkit.org/show_bug.cgi?id=133218

Reviewed by Dean Jackson.

* WebKit2.xcodeproj/project.pbxproj: Promote WKNavigationResponsePrivate.h to private.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Navigator object needs to have properties directly on the instance object
https://bugs.webkit.org/show_bug.cgi?id=133221

Reviewed by Mark Lam.

Flag the Navigator object as requiring properties to be on the instance
as there were a few compatibility issues when on the prototype.

* bindings/scripts/CodeGeneratorJS.pm:
(InterfaceRequiresAttributesOnInstance):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove 'css-shaders' option from the build-webkit
https://bugs.webkit.org/show_bug.cgi?id=133212

Patch by Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com> on 2014-05-23
Reviewed by Daniel Bates.

Original CSS shaders removed in r162644.

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed EFL gardening

* platform/efl/TestExpectations: Add test expectation for tests faling after r167840.
* platform/efl/fast/borders/border-antialiasing-expected.png: Rebaseline after r168046.
* platform/efl/fast/borders/border-antialiasing-expected.txt: Ditto.
* platform/efl/fast/forms/fieldset-align-expected.txt: Rebaseline after r168575.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed. Skip some snapshotting tests failing after r169173.
https://bugs.webkit.org/show_bug.cgi?id=133227.

* platform/mac-wk2/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
reset m_havePreparedToPlay when changing media engines.
https://bugs.webkit.org/show_bug.cgi?id=133199

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-05-23
Reviewed by Eric Carlson.

If a play request comes in before the media player is created, m_havePreparedToPlay
is set to true. But when the player is created, this prevents the new player from
getting the prepare call.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerEngineUpdated): set m_havePreparedToPlay false.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION (r169241) Crash running run-jsc-stress-tests on EFL ARM
https://bugs.webkit.org/show_bug.cgi?id=133223

Reviewed by Geoffrey Garen.

Change runAndMonitorTestRunnerCommand() to convert the *cmd argument to a
string before calling IO.popen() to work with older versions of ruby.
Changed the remote path in runShellTestRunner to quote the command
string we want to run via ssh so that it will work correctly with array
to string conversion needed for popen.

* Scripts/run-jsc-stress-tests:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Rebaseline some tests after r169260

* fast/dom/Geolocation/enabled-expected.txt:
* fast/dom/Geolocation/script-tests/enabled.js:
* js/dom/delete-syntax-expected.txt:
* js/dom/script-tests/delete-syntax.js:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Use a per app directory structure for website data
https://bugs.webkit.org/show_bug.cgi?id=133125
<rdar://problem/16830143>

Reviewed by Dan Bernstein, Sam Weinig and Tim Horton.

Put website data in subdirectories of ~/Library/WebKit/<bundle ID>/WebsiteData.
We use "LocalStorage", "WebSQL", and "IndexedDB" subdirectories.

* UIProcess/API/Cocoa/WKProcessPool.mm:
(websiteDataDirectoryURL):
(-[WKProcessPool _initWithConfiguration:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION(r169105): fast/regions/cssom/region-range-for-box-crash.html is more crashy than before
https://bugs.webkit.org/show_bug.cgi?id=133124

Reviewed by David Hyatt.

Source/WebCore:
When adjusting the end points of a subtree selection in the case of a document
with named flows, we have to make sure that we pass the computed end
points to the visible selection algorithm only if the end points are
part of the same subtree, otherwise assume a selection clear behavior.

The test fast/regions/cssom/region-range-for-box-crash.html is used to
test this behavior.

* rendering/SelectionSubtreeRoot.cpp:
(WebCore::SelectionSubtreeRoot::adjustForVisibleSelection):
(WebCore::SelectionSubtreeRoot::selectionStartEndPositions): Moved to header file.
* rendering/SelectionSubtreeRoot.h:
(WebCore::SelectionSubtreeRoot::selectionStartEndPositions):

LayoutTests:
Unskip the test file that used to crash.

* TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION (r153917): Chart for the Category Explorer within Quicken Essentials
does not draw until you force a redraw
https://bugs.webkit.org/show_bug.cgi?id=133228
<rdar://problem/15221231>

Reviewed by Simon Fraser.

* platform/RuntimeApplicationChecks.cpp: (WebCore::applicationIsQuickenEssentials):
* platform/RuntimeApplicationChecks.h:
Added a check for Quicken Essentials.

* platform/mac/WidgetMac.mm: (WebCore::Widget::paint): Don't do an early return
for Quicken Essentials, it depends on drawing to update its layer.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[CSS Grid Layout] Use gridRowCount() and gridColumnCount() when possible
https://bugs.webkit.org/show_bug.cgi?id=133213

Reviewed by Sergio Villar Senin.

Use gridRowCount() and gridColumnCount() instead of m_grid.size() and
m_grid[0].size() to make the code more descriptive and easier to
understand.

No new tests (No change in behavior).

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::growGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Rebaseline two tests affected by r169229.

* platform/mac-wk2/compositing/tiling/rotated-tiled-clamped-expected.txt:
* platform/mac-wk2/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove invalid ASSERT in wordRangeForPosition.
https://bugs.webkit.org/show_bug.cgi?id=133232

Reviewed by Ryosuke Niwa.

In WK2 for iOS this function is called on every selection change.
The selection could be set by Javascript in an element that is not visible.
In that case we won't be able to create a VisiblePosition therefore wordRangeForPosition
should not ASSERT that the VisiblePosition is not null, but rather
perform an early return if it is null.

* editing/VisibleUnits.cpp:
(WebCore::wordRangeFromPosition):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[iOS] WK2: Provide implementation for windowFrame
https://bugs.webkit.org/show_bug.cgi?id=133205
<rdar://problem/16894890>

Reviewed by Benjamin Poulain.

* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::windowFrame): Added.
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::convertToUserSpace): Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION (iOS WebKit2): Autocorrection is not accurate when changing selection.
https://bugs.webkit.org/show_bug.cgi?id=133237
<rdar://problem/16655776>

Reviewed by Ryosuke Niwa.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView beginSelectionChange]):
(-[WKContentView endSelectionChange]):

When the selection is changed with a gesture in an editable element,
we must notify the keyboard to make sure the autocorrection engine 
updates its typing context. WKContentView must implement
beginSelectionChange and endSelectionChange to call into
the keyboard layer.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Support inline caching of RegExpMatchesArray.length
<https://webkit.org/b/133234>

Give RegExpMatchesArray.length the same treatment as JSArray in
repatch so we don't have to go out of line on every access.

~13% speed-up on Octane/regexp.

Reviewed by Geoffrey Garen.

* jit/Repatch.cpp:
(JSC::tryCacheGetByID):
* runtime/RegExpMatchesArray.h:
(JSC::isRegExpMatchesArray):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169283 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Templatize GC's destructor invocation for dtor type.
<https://webkit.org/b/133231>

Get rid of a branch in callDestructor() by templatizing it for
the DestructorType. Removed JSCell::methodTableForDestruction()
since this was the only call site and it was jumping through
a bunch of unnecessary hoops.

Reviewed by Geoffrey Garen.

* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::callDestructor):
(JSC::MarkedBlock::specializedSweep):
* heap/MarkedBlock.h:
* runtime/JSCell.h:
* runtime/JSCellInlines.h:
(JSC::JSCell::methodTableForDestruction): Deleted.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove operationCallGetter

Rubber stamped by Filip Pizlo.

Nobody calls this function.

* JavaScriptCore.order:
* jit/JITOperations.cpp:
* jit/JITOperations.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
run-perf-tests should ignore whitespace lines when snarfing test output
https://bugs.webkit.org/show_bug.cgi?id=133238

Reviewed by Ryosuke Niwa.

Required for PerformanceTests/Canvas/terrain.html.

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest._run_with_driver):
(PerfTest):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@169286 268f45cc-cd09-0410-ab3c-d52691b4dbfc