regexp work but need to check attribute end if no ending symbol
better way to get valued attributes