trying to get edit params working