awesome!


On Wed, Feb 19, 2014 at 12:54 AM, Will <notifications@github.com> wrote:

> In spec/providers/storage/storage.isolated.unit.spec.js:
>
> >      var d = jasmine.createSpy('keys');
> >      provider.keys(d);
> > -    expect(provider.store.keys).toHaveBeenCalled();
> > -    expect(d).toHaveBeenCalledWith(['Test']);
> > +    setTimeout(function() {
>
> that was jasmine 1.3. Changed in jasmine 2.0 to take the 'done()' argument
> and call it after all asynchronous behavior has completed.
>
> I believe jasmine uses reflection on the test function to see if it takes
> a 'done' argument and uses that to decide if it needs to wait for asynch.
> completion. A bit magical, but seems to work & test effectively.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/UWNetworksLab/freedom/pull/45/files#r9854996>
> .
>



-- 
Lucas Dixon | Google Ideas