I agree with you, and this should happen in the entire system. But some
places need to be refactored to adapt to this changes when they occurs.

A think a better approach to static variables would be an observable
properties API so one can listen to these attribute changes an react
properly.

What do you think about?


2014-05-03 13:37 GMT-03:00 Oleg Nenashev <notifications@github.com>:

> In
> core/src/main/java/hudson/node_monitors/AbstractAsyncNodeMonitorDescriptor.java:
>
> > @@ -112,7 +112,7 @@ protected T monitor(Computer c) throws IOException, InterruptedException {
> >       * Controls the time out of monitoring.
> >       */
> >      protected long getMonitoringTimeOut() {
> > -        return TimeUnit.SECONDS.toMillis(30);
> > +        return Long.getLong(AbstractAsyncNodeMonitorDescriptor.class.getName()+".defaultTimeout", SECONDS.toMillis(30));
>
> I propose to create a static variable.
> Then users will be able to alter the value from Groovy scripts w/o restart
> (in emergency cases)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jenkinsci/jenkins/pull/1212/files#r12257117>
> .
>