Only add the `s` argument to global forum search queries if search-terms exist.

See #2607, #WP11330, [WP28623] [WP28612], [WP28804].

git-svn-id: https://bbpress.svn.wordpress.org/trunk@5468 9866e705-20ec-0310-96e7-cbb4277adcfb
Whitespace and brackets in main `bbPress` class.

git-svn-id: https://bbpress.svn.wordpress.org/trunk@5469 9866e705-20ec-0310-96e7-cbb4277adcfb
In `bbp_theme_compat_reset_post()` also set `is_singular` to value of `is_single`. Improves query compatibility with themes and other plugins. Props Mat Lipe. Fixes #2545.

git-svn-id: https://bbpress.svn.wordpress.org/trunk@5470 9866e705-20ec-0310-96e7-cbb4277adcfb
Use "Unfavorite" in `bbp_get_user_favorites_link()`. Fixes #2604.

git-svn-id: https://bbpress.svn.wordpress.org/trunk@5471 9866e705-20ec-0310-96e7-cbb4277adcfb
Use `wp_get_user_contact_methods()` in `bbp_get_user_contact_methods()`. See #2570.

git-svn-id: https://bbpress.svn.wordpress.org/trunk@5472 9866e705-20ec-0310-96e7-cbb4277adcfb
In `bbp_admin_repair_forum_topic_count()` include hidden topics in repair tool. Props thebrandonallen. Fixes #2680.

git-svn-id: https://bbpress.svn.wordpress.org/trunk@5473 9866e705-20ec-0310-96e7-cbb4277adcfb
Correct inline doc in `bbp_forum_get_subforums()`.

git-svn-id: https://bbpress.svn.wordpress.org/trunk@5474 9866e705-20ec-0310-96e7-cbb4277adcfb
Use `exclude` instead of post__not_in, in `bbp_get_forums_for_current_user()`.

git-svn-id: https://bbpress.svn.wordpress.org/trunk@5475 9866e705-20ec-0310-96e7-cbb4277adcfb
In `_bbp_has_replies_where()` remove the `post__not_in` check and add extra search/replace arguments for more complex queries. Improves support for popular privacy plugins that frequently use `post__not_in`. Props mikelopez. Fixes #2609.

git-svn-id: https://bbpress.svn.wordpress.org/trunk@5476 9866e705-20ec-0310-96e7-cbb4277adcfb
In `bbp_has_topics()` bring back `$default_topic_search` variable to prevent debug notices.

git-svn-id: https://bbpress.svn.wordpress.org/trunk@5477 9866e705-20ec-0310-96e7-cbb4277adcfb
In the `form-topic.php` template part, check for 'bbp_get_forum_title()` before outputting an empty title. Props jreeve. Fixes #2625.

git-svn-id: https://bbpress.svn.wordpress.org/trunk@5478 9866e705-20ec-0310-96e7-cbb4277adcfb