Fix L2 agent does not remove unused ipset set

The patch fixes L2 agent does not remove unused ipset set when security
group contains rules for only IPv4 or IPv6.

Change-Id: I375b1683cd763c0a33dc935558c637874d36ffa1
Closes-bug: #1373287
Enable assignment-from-no-return pylint check

The @versioning.versioned decorator used (only) in
plugins.vmware.nsxlib.router completely confuses this check, so add a
file-local pylint disable.

Change-Id: I2a79a643a982f49faaf22b88764cb170ef89ce21
NEC plugin: Allow to apply Packet filter on OFC router interface

Config parameter support_packet_filter_on_ofc_router is added
only to make the pluign work with the old version of PFC v5
which has no support of packet filter on vrouter interface.

Closes-Bug: #1384263
Change-Id: I2f54419e0b7c84c554ab2039ebaebdb065f9e502
Add assertion to test_page_reverse method

In neutron/tests/unit/test_api_v2.APIv2TestCase.test_page_reverse
there is no second call to test_case with 'page_reverse': 'False,
because of use assert_called_once_with.
In proposed change before second testcase, reset_mock is called.
Remove also second 'instance' initialization.

Closes-Bug: #1373126
Change-Id: I552b7b47456a1cdfccdeb8d7853ec3395317097a
Remove duplicate ensure_remove_chain method in iptables_manager

Change-Id: I168eda2fa430446786d4106d6807207f4facbfc3
Closes-Bug: #1388162
Purge use of "PRED and A or B" poor-mans-ternary

Since python2.6, python has a proper ternary construct "A if PRED else
B".  The older idiom "PRED and A or B" has a hidden trap - when A is
itself false, the result is (unexpectedly) B.

This change removes all cases of the older construct found using a
trivial git grep " and .* or " - except one case in oslo common
code (fixed in oslo upstream).

Change-Id: I24461f4328e188c8983ad574495e11e033ec5ba4
SRIOV: Fix Wrong Product ID for Intel NIC example

Some Examples and default Values of the Product ID for Intel NIC contains
Wrong Product ID that belongs to the PF product,
it should be replaced with the product ID of the VF.

Change-Id: I87291ea0458fa1ef7df1c06e17b7f9071ffb39e0
Closes-Bug: 1387152
Update default value for agent_required attribute

Update default value for agent_required under the
section [ml2_sriov] to be aligned with default config value.

Change-Id: I5903dedb2b8dc6bbda7c921ef747ffae358b3c05
Closes-Bug: 1386660
Fix L3 HA network creation to allow user to create router

Update HA Network creation to use an admin context to allow Neutron
to create the tenant-less network required for the HA router when
it does not yet exist and is being created by a non-admin user.

Neutron creates these resources without a tenant so users cannot see
or modify the HA network, ports, etc.  Port creation and association
already use elivated admin contexts to allow their function when
an user attempts to create a HA L3 router.

Change-Id: I36166158a0970b8d08d6702054b11a43fb684281
Closes-Bug: #1388716
rootwrap config files reference deleted quantum binaries

dhcp and l3 rootwrap filter files contain reference to the deleted
binary quantum-ns-metadata-proxy. This change removes these obsolete
filters.

Change-Id: Iad4772752d74a1c0535144b5faf9a1f8ae89f6a3
Closes-Bug: #1391256
Remove openvswitch core plugin entry point

The openvswitch core plugin has been removed but not its associated
"neutron.core_plugins" entry point. This change removes it from
setup.cfg.

Change-Id: I79f7c334cdeb0f4d0d68743734f69c0ec8523467
Related-Bug: #1323729
Closes-Bug: #1391326
Merge "Fix L3 HA network creation to allow user to create router"
Merge "SRIOV: Fix Wrong Product ID for Intel NIC example"
Merge "Remove duplicate ensure_remove_chain method in iptables_manager"
Merge "Add assertion to test_page_reverse method"
Merge "NEC plugin: Allow to apply Packet filter on OFC router interface"
fix event_send for re-assign floating ip

Neutron can associate a floating ip to a new port
without disassociate from original instance port.
This situation will send network changed event only
for new instance port, and that event object contains
the new instance's id.

In this case nova will update new instance's info
but not original one's in nova's database table
instance_info_caches. For nova can get new instance's
id from the above event. So in table instance_info_caches,
both original instance and new instance will have the
same floating ip in their records. And this make it
possible that, in most situation, after your re-assign
floating ip, run "nova list" will return incorrect info,
multiple instances have a same floating ip, and this may
confuse users.

Nova will sync data in table instance_info_caches, but it
may take dozens of seconds.
The new added code will send network changed event for the
original instance, and this will make nova update instance_
_info_caches table in a few seconds.

Change-Id: If3ee11535f649fc51bf1a52806008c1c5c0e73b6
Closes-Bug: 1381886
Merge "Enable assignment-from-no-return pylint check"
Fix missing allowed command in openvswitch xenapi agent

Add allowed command "ovsdb-client" to ALLOWED_CMDS list.

Change-Id: I274604229f90ba00722b1001cbc7404cd3e8070d
Closes-Bug: #1338447
Merge "rootwrap config files reference deleted quantum binaries"