docs(menus): improve docs for menu item factory

Clarifies that the 2nd argument for elgg_register_menu_item() is used
as the arguments for ElggMenuItem::factory() and the options PHPdocs
are moved to factory().
Merge pull request #7348 from mrclay/menuitem_docs

docs(menus): improve docs for menu item factory