remove unnecessary and confusing line

XShapeGrouper.group returns a XShapeGroup
which is guaranteed to also be a XShape.
If it were not a XShape, this code would not even work
since the first assignment would not work,
since xShapeGroup is of type XShapeGroup.

Change-Id: Ic0d873229a1421c3dc94292d7449614a4b6140a3
fdo#87301 don't rely on the shape to get the control

as it forgets its associated control

Change-Id: Ia5bd2212725376ab629f2c271102cea2cff9e823
fix indentation

Change-Id: I13b50f49658a9ca38dc9a41b219428d5faad70a3
Revert "fix indentation"

This reverts commit 534e5676028e41205adba3928f96cd35559b5dca.
Revert "fdo#87301 don't rely on the shape to get the control"

This reverts commit 89b3af722cc13a0af06822afe248cdec3b63cfeb.
set *content* control to multiline, not label(!)

Change-Id: Iebf7fa5b2335e5c6d71fdba791e49a6378db8a31
this is purely informative, SAL_WARN is overkill

Change-Id: Iccb98e50a678e5c53b69fb1052e3dac83cdcf5f5
two references having same content

Change-Id: I2db8842411e39d7d100d0627f8c930bb3f633d77
teach XML import/export about unsigned integer types

resolves a shitload of warnings like

warn:legacy.osl:941:1:xmloff/source/forms/elementimport.cxx:426: OElementImport::implImportGenericProperties: unsupported value type!
warn:legacy.osl:941:1:xmloff/source/forms/elementimport.cxx:443: OElementImport::EndElement: could not set the property "ObjIDinMSO"!
warn:legacy.osl:941:1:xmloff/source/forms/elementimport.cxx:444: caught an exception!
in function:void xmloff::OElementImport::implApplyGenericProperties()
type: com.sun.star.lang.IllegalArgumentException

Change-Id: Ia598d12e7d9429fe4ad3b1e7173e11e75060a613
Don't assume that the ZOrder property of shapes is an enumeration

...at least when we can easily not assume it.

shapes = shapes of the same XShapes
an enumeration = it is the sequence 0, 1, 2, 3, ..., XShapes->getCount()-1

We replace the ZOrder property by the index of the XShape in the
XShapes (the same XShapes that is passed to seekShapes()... when that
is easy to find. Else, use ZOrder and hope for the best.

ZOrders are not always an enumeration. For example, in documents
(forms) created by the Base forms wizard, it is not the case.

The wrong assumptions was leading to the following bugs in the Base
form wizard:

 - Only the first two controls in the form were successfully saved. The
   others were just dropped.

 - Whereas the labels had the proper style (background and text
   colour) applied while creating the document, these were not saved
   successfully

Change-Id: I15b9a3ef3b16eafa9698332e35d82d51d51627f8
xShapeGroup *is* the control's global xShape, so use it as such

this allows the rest of the code to automagically do the right stuff:
 - get&set position
 - group this control with its label
 - set the label property to the label control
 - ...

Conflicts:
	wizards/com/sun/star/wizards/document/TimeStampControl.java

Change-Id: Ibf3cb0ae82ba5c8a23fde05f6466f8eec8308186
detect groupShapes (TimestampFields) in forms, too

as a consequence, successfully delete them

Change-Id: I5dd7b329708dd13f8bfe4a38974c5f6f1202b392
GroupShape takes care of scaling the subshapes

Change-Id: I1e913287229119276fa97f73cb249ed0a0b2c473
Keep as xShapes the newly created GroupShape

That's what we should refer to later, not the temporary collection we made!

Change-Id: Ie288222c6aefa0f50a0b0878ad83b78909ee56d1
protect against division by zero

Change-Id: Ib91120e626f772bb52531c4a35fc70f04cc5c48f
janitorial

Change-Id: I3e79b0b34507b947ac4234bab45265027e445d7f
janitorial

Change-Id: I91387b354d0034410819dbcb8dc1ad8889fc8f14
Assume that as long as the model is the same, the shape doesn't change.

Even if it is moved from not a page to a page or vice-versa.
This allows assumptions made in the Base Form wizard to hold,
namely that if one:
1) Creates controls (and their associated shapes)
2) Groups the shapes (in a GroupShape)
Then all the shapes still remember their associated control
and vice-versa.

Change-Id: I31975970e7ea2f7978aea7f753de88ecd8e55234
survive "TextBox" having no value

Change-Id: Iebed41cfcc5899387e3defb8d8a0792276349098
correct function name in debug message

Change-Id: I9c02fdd99504bdee6654d1072559a4afac6532a3