comitting view changes