Removed ndiff from POSIXFile, only attempt unified diff.

This removes the ndiff, which is a bit extraneous and can cause up to 30 second
timeouts on larger files with many changes. unified_diff is faster and
generally more applicable, and is already what is shown to the admin on
interactive mode. This can save up to 30 seconds per file, per run.

A future commit can take the resulting unified diff and recreate the ndiff
specifically for the reporting if that is desired.
Yep, probably. That was part of the code before so I left it in case it was
necessary.

Would definitely simplify things.
 On Aug 19, 2014 3:22 PM, "Sol Jerome" <notifications@github.com> wrote:

> In src/lib/Bcfg2/Client/Tools/POSIX/File.py:
>
> >                  if diff:
> > -                    udiff = '\n'.join(l.rstrip('\n') for l in diff)
> > +                    udiff = '\n'.join(l for l in diff)
>
> Can you just do '\n'.join(diff) here instead?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Bcfg2/bcfg2/pull/188/files#r16440939>.
>