Actually, I adapted those changements from the most recent adaption of your script in the pacman repository. But now that I look at it, it doesn't even make any good sense. So those changements are not from me and I don't seee any good reason for it. I simply took the source from th pacman repo and fixed the bugs in install-spotify.sh and spotify-client.spec . And yes, it is a good idea to accept it as a short-term fix, because spotify is a popular programm and people will get driven away from opensuse if there is an installer-script in the internet which doesn't work with the newest version of the distribution.
Thanks and have a nice day!