selftest: Show filename or script we had trouble reading

Change-Id: I12c26e807ab0d65031347bc3be609b2e87dcabb5
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>
s4-auth: Use sizeof() rather than a fixed constant in memcmp() call

Change-Id: I2807cf2af9e4c3282e6ff54a6dd8e90f34e9481f
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>
passdb: Avoid use-after-free when setting a plaintext password

The issue here is that pdb_set_plaintext_passwd() re-used the memory from pdb_get_pw_history() as input

We need to free this after we copy and set it.

Found by AddressSanitizer

Andrew Bartlett

Change-Id: I4e148e23ccbbe5444c969ff8f91709791c7696bb
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>
Use correct size for test string, sizeof() was of the pointer

Found by AddressSanitizer

Change-Id: Ifc9883d958f253df903775544010c0228a102f0f
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>
s3-lib: Do not walk past the end of the dos_to_ntstatus_map array

Found by AddressSanitizer

Change-Id: Ic8b3e2599713c37b11324f9ec2d01891f0f287b9
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>
torture: allow us to correctly use sizeof(buf) in raw.open tests

This changes the sizeof(buf) from sizeof(void *), 8 on 64-bit machines, to sizeof("test") (eg 5).

Found by AddressSanitizer

Andrew Bartlett

Change-Id: I01f18b35c041f3b16be9f6da8ae5d1917d7e24d9
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>
winbindd: Do not use user_list->out.resume_index after free

Found by AddressSanitizer

Change-Id: I9f8b95b65de788994a7404fa8889fce45ccb3a30
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>
winbindd: Do not use group_list->out.resume_index after free

Found by AddressSanitizer

Change-Id: I59009144b28c390ddb80b7b3fbb4007dfd16db0e
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>
s3: smbd: smb2-sessionsetup. Fix use after free when the sessionsetup request state is freed before struct smbXsrv_session struct.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Sep  8 09:52:23 CEST 2014 on sn-devel-104
util/debug: Use talloc_autofree_context() instead of NULL to reduce the noise

Signed-off-by: Kamen Mazdrashki <kamenim@samba.org>
util/debug: debug_list_class_names_and_levels - alloc mem off of autofree context

This is a bit special case for direct replacement of NULL top level
context with autofree context as it does string appends on it
It is also in way not strictly needed to use autofree context here
as this function is used only once and caller frees allocated memory

Signed-off-by: Kamen Mazdrashki <kamenim@samba.org>
ldb_modules: use talloc autofree context to allocate global pointers

Signed-off-by: Kamen Mazdrashki <kamenim@samba.org>
tevent: Allocate tevent_ops_list structures in autofree context

This is to reduce the noise when doing memory leak checking
in Unit tests for instance

Signed-off-by: Kamen Mazdrashki <kamenim@samba.org>
loadparm: Allocate bitmap structures in autofree context

This is to reduce the noise when doing memory leak checking
in Unit tests for instance

Signed-off-by: Kamen Mazdrashki <kamenim@samba.org>