Fix 'expect() without .to' assertation error

We've seen this common error in other tests. When `expect ==` is used
without the '.to', the test passes regardless.

Eg

    expect(false) == true    # passes

This pitfall can be avoided by always using a matcher, eg:

    expect(false) eq(true)   # gives syntax error

This commit fixes all assertations to use:

    expect(thing).to eq(value)

It has highlighted some broken tests. These will be fixed up in the
following commit.
Fix broken test - wrong value tested
Fix intermittent :ip_ranges test failure

The ip_ranges list coming back from vcloud_attributes is
not returned in a defined order -- hence the test fails intermittently.

This commit fixes up the test to confirm the contents of the array are
as required, rather than the failing equality check.
Use Rspec match_array matcher for brevity

match_array matcher covers our 3 assertations here to essentially
ensure our returned array matches our configuration, but potentially
reordered.
Merge pull request #22 from alphagov/70443650_fix_integration_tests

[Prep work for #70443650] Fix broken integration tests