This is an interesting question. 

Regarding whether or not it's actually correct: it is, because that number is just used for versioning. As long as that changes when the class layout changes, serialization will continue to work with old files.

With that said, I always thought generated version ids were right. 

For a long time, I've always done generated versions for serializations. However, recently you checked in a few files that used 1L, which is one of the options eclipse gives to resolve the serialization version warning. I researched it, and it does seem that well known developers start 
with one, and then increment it with each new version.

As I've thought about it, I see a lot of logic in starting with 1 for version 1 of a class. I'm definitely interested in hearing thoughts about problems with this, of course. 

Chris


> On Mar 27, 2014, at 9:39 PM, Aaron Heuckroth <notifications@github.com> wrote:
> 
> In bubolo/src/bubolo/controllers/Controllers.java:
> 
> > @@ -72,6 +72,8 @@ public void createController(Entity entity, ControllerFactory factory)
> >  		// TODO: Add default factories here.
> >  		
> >  		factories.put(Tank.class, new ControllerFactory() {
> > +			private static final long serialVersionUID = 1L;
> I don't know much about how the serialization code works, but is this supposed to be a 1, instead of a unique serial?
> 
> I'm guessing it doesn't matter because these factories will not be serialized.
> 
> —
> Reply to this email directly or view it on GitHub.