update all method to get 2 parameter