Ok Ray,

Thanks again for you comments.  I've updated that valid_result? function to
return true when all else has proven false, logging errors along the way.

bbye,

Mike


On Wed, Apr 23, 2014 at 6:06 PM, Ray Davis <notifications@github.com> wrote:

> In app/models/ets_blog/alerts.rb:
>
> > @@ -54,14 +53,13 @@ def xml_source
> >
> >      def valid_result?(r=nil)
> >        valid = true
>
> @chikoon <https://github.com/chikoon> , the new logic basically leaves
> "valid" without a reason to exist. In this code it will always be true.
>
> However, the new logic also leaves us without any log message about
> invalid items, which seems like a more serious issue. Could you make sure
> problems are logged somewhere? Thanks!
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ets-berkeley-edu/calcentral/pull/2413/files#r11908097>
> .
>