Update setBooleanFieldValue and bug fixes

setBooleanFieldValue was implicitly converting “Yes” and “No” to an
always true bool. This corrects the existing implementation bugs and
updates setBooleanFieldValue to throw a link time error for the future.
Fix various compiler warnings

This fixes various compiler warnings output by Clang 5.1.

Some are simple unused variables, which if need to be used in the
future will have to be added again.

I also added -Wno-dynamic-class-memaccess compile flag for swig targets
to get rid of a clang specific warning (annoying warning) [1]. I don’t
think this is something to worry about from my research but I also can
not figure out a way to fix the warning, other than to suppress it.

For the changes in ServiceWaterGridItems, the compiler was implicitly
converting the double’s to int’s since the various Qt functions use int
parameters. This just changes the doubles to the implicitly converted
int, explicitly.

GeometryTranslator was only applying the ’not’ to the left hand side of
the equation [2]. This worked because objects.size() for
GlobalGeometryRules and Building should be 0 or 1 only since they are
unique objects. Thus the ’not’ operator would flip these and compare to
1. This just changes the comparison to != which can deal with size() >
1 (but shouldn’t ever happen)

[1] - Warning
~/osbuilds/develop_branch/OpenStudioCore-prefix/src/OpenStudioCore-build
/src/utilities/ruby_OpenStudioUtilitiesDocument_wrap.cxx:3267:9:
warning:
      destination for this 'memset' call is a pointer to dynamic class
      'openstudio::DocumentElement'; vtable pointer will be overwritten
      [-Wdynamic-class-memaccess]
        memset(v_def,0,sizeof(Type));
        ~~~~~~ ^
~/osbuilds/develop_branch/OpenStudioCore-prefix/src/OpenStudioCore-build
/src/utilities/ruby_OpenStudioUtilitiesDocument_wrap.cxx:3293:66: note:
      in instantiation of member function
      'swig::traits_as<openstudio::DocumentElement,
swig::pointer_category>::as'
      requested here
    return traits_as< Type, typename traits< Type >::category
>::as(obj, te);
                                                                 ^
~/osbuilds/develop_branch/OpenStudioCore-prefix/src/OpenStudioCore-build
/src/utilities/ruby_OpenStudioUtilitiesDocument_wrap.cxx:5053:114:
note:
      in instantiation of function template specialization
      'swig::as<openstudio::DocumentElement>' requested here
  ...openstudio::DocumentElement > >::value_type val =
swig::as<std::vector<o...
                                                             ^
~/osbuilds/develop_branch/OpenStudioCore-prefix/src/OpenStudioCore-build
/src/utilities/ruby_OpenStudioUtilitiesDocument_wrap.cxx:3267:9: note:
      explicitly cast the pointer to silence this warning
        memset(v_def,0,sizeof(Type));
               ^
               (void*)

[2] - Warning
logical not is only applied to the left hand side of this comparison
      [-Wlogical-not-parentheses]
    if (!objects.size() == 1){
        ^               ~~
Merge branch 'develop' into FixCompilerWarnings
Adding isSolarDiffusing method to ConstructionBase for Rob

[#68855214]
Version numbers updated for v1.3.3 [#69733384]
Merge branch 'develop' into FixCompilerWarnings
some updates to experimental workflow

some old fixes I forgot to commit and some new fixes found from user
file
fix for flipped group or components

Found code online to look for scale of -1 to address groups flipped
along axis.
fixed issues with doors

still issue if base surface split under door. In future may have
sub-surfaces as a component. This will also allow offset.  Next step is
probably to make stand alone plugin, then I can add more features to
that (e.g. add in data to model to support render modes)
Update ConstructionBase.hpp

Correcting comment
Merge pull request #998 from NREL/68855214_isDiffusing

Adding isSolarDiffusing method to ConstructionBase for Rob
Merge pull request #881 from ORNL-BTRIC/Update_setBooleanFieldValue

Update setBooleanFieldValue and bug fixes
Merge pull request #915 from ORNL-BTRIC/FixCompilerWarnings

Fix various compiler warnings
Merge remote-tracking branch 'origin/develop' into enable_java_support

Conflict was only in the whitespace

Conflicts:
	openstudiocore/ProjectMacros.cmake