finish basic modal login