Fixed and pushed

From: Ritesh Maheshwari <notifications@github.com<mailto:notifications@github.com>>
Reply-To: linkedin/naarad <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Monday, March 17, 2014 5:07 PM
To: linkedin/naarad <naarad@noreply.github.com<mailto:naarad@noreply.github.com>>
Cc: Shaoshan Liu <shliu@linkedin.com<mailto:shliu@linkedin.com>>
Subject: Re: [naarad] Extend Diff to support URL based CDF csv file paths, also Fix issue 149: cdf not plotted for sar important metrics (#155)


In test/test_diff.py:

> +from naarad.reporting.diff import NaaradReport
> +logger = logging.getLogger('naarad')
> +
> +diff_obj = None
> +
> +def setup_module():
> +  global diff_obj
> +  reports_list = []
> +  report_name = 'diff'
> +  output_directory = ''
> +  resource_directory = ''
> +  resource_path = 'resource_path'
> +  naarad_reports = [NaaradReport('/tmp', None), NaaradReport('/tmp', None)]
> +  diff_obj = Diff(naarad_reports, 'diff', '/tmp', '/tmp', 'resources')
> +
> +def test_collect_cdf_datasources():


I am asking if this test fails since the method it calls will try to copy files as well....

—
Reply to this email directly or view it on GitHub<https://github.com/linkedin/naarad/pull/155/files#r10686691>.