Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

Change-Id: Id38f366c04edcf3326b323fc851a6644a942d79d
Reviewed-on: https://code.wireshark.org/review/1453
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

Change-Id: I8ab25b1a3326ade46408ebd2e14cf841191c57d9
Reviewed-on: https://code.wireshark.org/review/1454
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Fix Dereference of null pointer found by Clang analyzer

packet-teamspeak2.c:456:21: warning: Access to field 'fragmented' results in a dereference of a null pointer (loaded from variable 'frag')

Change-Id: Ie253991f8d664c4594254bcd4569883614aafe2f
Reviewed-on: https://code.wireshark.org/review/1455
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Unreachable code in ui/gtk/main.c

Unreachable code due to conflicting defines: checking for GTKOSXAPPLICATION inside _WIN32

Found by Edwin

Closed-bug: 10065
Change-Id: I074fa14069e859b3fc4b7f50c443a67e7f0e954b
Reviewed-on: https://code.wireshark.org/review/1456
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Add OSPF Authentication Trailer (RFC6506)

Change-Id: Ie5c536a6977e35acc12222af3c48d29740cd57f2
Closed-bug:9941
Reviewed-on: https://code.wireshark.org/review/1440
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Fix -Wunreachable-code found by Clang

Change-Id: I895194655ff674fff5e84fa93b3f9a00a0f70e27
Reviewed-on: https://code.wireshark.org/review/1457
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Cleanup SPDY dissector.

Address Evan's missed comments from https://code.wireshark.org/review/767/

From Alexis La Goutte
Fix unused variable (pinfo) and fix crash (wrong variable in while)

Change-Id: I1b134585f4d522d3e808069f606beb4aae0488fa
Reviewed-on: https://code.wireshark.org/review/1164
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Evan Huus <eapache@gmail.com>
Add a comment re VS2013EE requiring that win32.mak needs to be separately obtained.

Change-Id: I53413f7bdde50149fd923bbe35c995145d5139f2
Reviewed-on: https://code.wireshark.org/review/1458
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Add a comment re certain variables beibg defined in win32.mak.

Change-Id: I9246a1786a5bf8c48744378f25a66f6881caed81
Reviewed-on: https://code.wireshark.org/review/1459
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Remove 'include win32.mak' from certain nmake files when not needed.

Change-Id: I05a505d884abb5fd7fca87bb89af29e3e4502b74
Reviewed-on: https://code.wireshark.org/review/1460
Reviewed-by: Bill Meier <wmeier@newsguy.com>
MBIM: dissect MBIM_SET_STK_PAC and MBIM_STK_PAC_INFO messages

Change-Id: Ib58dece7ce7278e292d88f68368c238695c32394
Reviewed-on: https://code.wireshark.org/review/1463
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Add support for Logical Link Down TLV.
TLV is 1 octet long, and only MSB holds info with 7 unused bits

Change-Id: Ic1f5ce1b774bb7439cd2a23bc9bfb44f7dc25888
Signed-off-by: Anish Bhatt <anish@chelsio.com>
Reviewed-on: https://code.wireshark.org/review/1450
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Fix Dereference of null pointer found by Clang analyzer

Also add modeline info and use _U_ only when it is needed (for pinfo)

Change-Id: I71349d6451e1d8304fad04781e5ee226a1a4c729
Reviewed-on: https://code.wireshark.org/review/1466
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Add a new Dissector for HiSLIP

Change-Id: I87aaf4c8093ee8013a661aa8af81dba63eaa7086
Signed-off-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-on: https://code.wireshark.org/review/1337
Optimize wmem_strbuf_grow.

As suggested by Anders, in the case of repeated calls to wmem_strbuf_append_c
(and other functions which append very little data) the growth check was a
substantial portion of the over-all running time. By short-circuiting the check
in the case where growth isn't needed (as opposed to letting it fall-through
naturally) we shave ~25% off the cost of such repeated calls in my benchmarks.

The function (wmem_strbuf_grow) is inline, so the compiler should be able to
optimize each caller individually for the short-circuit.

Change-Id: I76419020f4d8fa675906eb77798969b6c61c7732
Reviewed-on: https://code.wireshark.org/review/1467
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Reintroduce wmem_allocator_force_new

We now have to call wmem_init in order to randomly seed the values for wmem_map.
This means we can no longer rely on the lack of override, so we have to force
the right allocator type when testing/timing the allocators themselves.

Change-Id: I005034465b0a98f19876899b96ef65b3e4b1d759
Reviewed-on: https://code.wireshark.org/review/1468
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Add modelines info

Change-Id: I82f841e0ee9e00c69894d8c4c67f581278c87546
Reviewed-on: https://code.wireshark.org/review/1469
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Add modelines info

Change-Id: I35bed12af5e0a2da9daf2fb5b6dfdfe05377549e
Reviewed-on: https://code.wireshark.org/review/1470
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Enhance display of SPDY packet (Remove some information from column)

Fix also tvb_length / tvb_length_remaining soft warning

Change-Id: I3fd8f3a842fa84273b84ae36317e2c3fbdca076d
Reviewed-on: https://code.wireshark.org/review/1461
Reviewed-by: Anders Broman <a.broman58@gmail.com>
wmem: add new simple block allocator, use it in packet-scope.

For packet-scope allocation, there's no need to support realloc(), free()
cause memory will be garbage collected after packet dissection.

(and this allocator is much faster than full block allocator).

Change-Id: I73fdf708c3077f48f55bdcc71f4fa859e4ac2335
Reviewed-on: https://code.wireshark.org/review/1428
Reviewed-by: Anders Broman <a.broman58@gmail.com>