CS fixes and tidy up of tests

They're both no big deals

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/


On 11 June 2014 23:29, Antonio Vilar <notifications@github.com> wrote:

> In tests/Doctrine/Tests/Common/Collections/CriteriaTest.php:
>
> >  {
> >      public function testCreate()
> >      {
> >          $criteria = Criteria::create();
> >
> > -        $this->assertInstanceOf("Doctrine\Common\Collections\Criteria", $criteria);
> > +        $this->assertInstanceOf("Doctrine\\Common\\Collections\\Criteria", $criteria);
>
> I can't seem to find any standard talking about escaping backslashes.
> You're right, there's no need to escape it if the following char is
> uppercase, though I just find it a good practice, so you know it's always
> going to be safe (there's no need to check you're not using a special
> character).
>
> I think it's a matter of personal preferences. I'm happy to leave a single
> quote if that's what the majority prefers.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/doctrine/collections/pull/31/files#r13675473>.
>