Hello,
 I fully understand the reason why you want to add this.

But I'm just afraid that all already existing drivers hasn't this item in
API structure , so there won't be a NULL pointer and the code crash. Any
idea is welcomed.

The original idea (not implemented yet) is create the API on d4d_low.c file
to be able to handle intelligent drivers that can draw the elementary
objects (line, rectangle, circle, etc), but this is just not realized idea.
The biggest problem is defined API between "d4d_low.c" and high eGUI.


This is reason why I don't want add this without larger discussion and
test. For rest of your work on eGUI I'm really happy for your work and I'll
implement it when I will be on my PC.

Thank you


2014-03-03 20:48 GMT+01:00 Spencer Oliver <notifications@github.com>:

> In D4D/common_files/d4d_low.c:
>
> >    // Set the logic window on LCD
> >    (void)D4D_LLD_LCD.D4DLCD_SetWindow(x1, y1, x2, y2);
> >
> > +  // use fill rect if available
> > +  if (D4D_LLD_LCD.D4DLCD_FillRect) {
>
> D4DLCD_FillRect will only be used if it has been declared by the driver.
> As it would default to NULL anyway I do not see an issue with backwards
> compatibility.
>
> A driver like the S1D13506 has bit-blit functions and requires this kind
> of feature to make updates fast as possible.
>
> Most other drivers I have used offer a way of supporting drivers that
> support certain primitives, line, arc, circle, rect etc. Sometimes the
> driver may know a better way.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/Gargy007/eGUI/pull/2/files#r10225320>
> .
>