From Martin Mathieson:
For S1AP PDUs that contain a cause, show that cause in the Info column.

Change-Id: Icecb8da278c16e0d47395b17b54dee6ebd7be646
Reviewed-on: https://code.wireshark.org/review/1170
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Add missing MPCP messages as per IEEE 802.3 Standard

Added following message types:
  * GATE
  * REPORT
  * REGISTER REQ
  * REGISTER
  * REGISTER ACK

Change-Id: I005d92289cf3a8d46f3786184d18ce500863541e
Reviewed-on: https://code.wireshark.org/review/1128
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Fix packet-maccontrol.c:147: warning: format not a string literal and no
format arguments

Change-Id: I57305c7c6be86a706f10ac2c08f6576bd41eac94
Reviewed-on: https://code.wireshark.org/review/1172
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Philip Rosenberg-Watt <p.rosenberg-watt@cablelabs.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Added David Miller and Philip Rosenberg-Watt to file info.

Change-Id: I5f9248d58a4e809ed2fffd714411ab2e0fcc283d
Reviewed-on: https://code.wireshark.org/review/1171
Reviewed-by: Anders Broman <a.broman58@gmail.com>
USB: fix 'Decode As' by USB Device functionality

Change-Id: I22a997939f456dd4c4baecd7dd1aedc3ffefcc82
Reviewed-on: https://code.wireshark.org/review/1173
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Make dissect_nbss() a bit more like tcp_dissect_pdus().

Move some stuff out of dissect_nbss_packet() to dissect_nbss(), to make
its main loop look a bit more like tcp_dissect_pdus()' main loop, and
then pick up some changes from tcp_dissect_pdus().

Also, have the "Length" field cover not only the field nominally
designated as a length field, but also the low-order bit of the flags
field, because that bit is really the 17th bit of a 17-bit length field
(RFC 1002 even speaks of it in those terms).

Change-Id: Ia95912163c23d482bfca6c026d92aadbd0ca8ac4
Reviewed-on: https://code.wireshark.org/review/1175
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Fix "might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]" warning from gcc 4.9

Rework code related to TRY_SCSI_CDB_ALLOC_LEN macro to simplify and clarify same.
Rename some vars to catch any incorrect usage.

Change-Id: Ibf9465c5ce7670aa1147e0c311c37e582ece427a
Reviewed-on: https://code.wireshark.org/review/1177
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Tested-by: Bill Meier <wmeier@newsguy.com>
Fix "might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]" warning from gcc 4.9.

Change-Id: I99f777b3058e1cef3e1a077ffde259f0d2f51c98
Also: rename some vars to catch any incorrect usage.
Reviewed-on: https://code.wireshark.org/review/1178
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Tested-by: Bill Meier <wmeier@newsguy.com>
Fix gcc "might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]" introduced by 19a3d046f2

[Apparently (at least) the Ubuntu buildbot gcc (presumably < 4.9) needs two vars
to be marked volatile even though gcc.4.9 (Fedora) doesn't.

Change-Id: Icf95511d08a31547196874aecb60d85cab975cfb
Reviewed-on: https://code.wireshark.org/review/1179
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Tested-by: Bill Meier <wmeier@newsguy.com>
Fix a [pedantic] gcc warning: "empty macro arguments are undefined in ISO C90 and ISO C++98"

Change-Id: I09f05bb1af1da20eb1a0675ed56fbe7e6b769d68
Reviewed-on: https://code.wireshark.org/review/1180
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Tested-by: Bill Meier <wmeier@newsguy.com>
Use Lua 5.2.3 linked against MSVCR110.DLL when compiling with MSVC2012

Change-Id: I372ca3b6ad80ee5a3073d06bccd3986a6d7ba27f
Reviewed-on: https://code.wireshark.org/review/1176
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Switch to using the ASN1 based kerberos dissector.

Change-Id: Ib8945cdad149b71e3f79bd88032fd10f55ba556d
Reviewed-on: https://code.wireshark.org/review/1174
Reviewed-by: Anders Broman <a.broman58@gmail.com>
From: Alvaro Neira Ayuso <anayuso@sysmocom.de>
fix SW_DESCR decoding
 error

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9993

Change-Id: Ia722239797ae4458d5cf880a54b6d358dc108b64
Reviewed-on: https://code.wireshark.org/review/1181
Reviewed-by: Anders Broman <a.broman58@gmail.com>
From zeljko:
Preferences for the MRCPv2 protocol, TCP port is converted from a single port to a port range field.

Change-Id: Ieb7a7a9beb8474fe89531742d39d5ed6f6862637
Reviewed-on: https://code.wireshark.org/review/1182
Reviewed-by: Anders Broman <a.broman58@gmail.com>
ssl: Detect unencrypted heartbeat messages

Records are always unencrypted before the ChangeCipherSpec message. This
patch assumes that conversations without a SSL decoder (i.e. before
calling ssl_change_cipher) are unencrypted. If it turns out that the
contents were encrypted anyway, then there is about 0.8% probability
that the heartbeat message gets recognized wrong
(dissect_ssl3_heartbeat checks if the first byte equals 1 (request) or 2
(response)). Not a big deal, and the advantage that the heartbleed
expert information is triggered overweights that possible mistake.

(Note that ssl_set_master_secret as called by external code will also
invoke ssl_change_cipher, but that should be caught by the if
condition in the line before this hunk.)

An example capture is available at:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9988

Change-Id: I5b14d9e7e8e0c1cd358f3b05c9b84fca1daf1d69
Reviewed-on: https://code.wireshark.org/review/1102
Reviewed-by: Evan Huus <eapache@gmail.com>
From Graham Bloice:
Fix A mismatch in the dnp3_al_obj_vals value string fixes bug
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9945

Change-Id: I3d0a423d7d2e4a711533debbd950e2976dd5115e
Reviewed-on: https://code.wireshark.org/review/1183
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
remove duplicated entries.

Change-Id: I1fcbda17cbc444eee04e975d60b371fc2fa4754c
Reviewed-on: https://code.wireshark.org/review/1184
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Add tvb_get and proto_tree_add for string-encoded byte arrays

This commit adds tvb_get_string_bytes and proto_tree_add_bytes_item routines for
getting GByteArrays fields from the tvb when they are encoded in ASCII hex string form.

The proto_tree_add_bytes_item routine is also usable for normal
binary encoded byte arrays, and has the advantage of retrieving
the array values even if there's no proto tree.

It also exposes the routines to Lua, both so that a Lua script can take
advantage of this, but also so I can write a testsuite to test the functions.

Change-Id: I112a038653df6482a5d0ebe7c95708f207319e20
Reviewed-on: https://code.wireshark.org/review/1158
Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Try to fix bug 10000.

This involves duplicating macros, but at least it

	1) doesn't have empty arguments to macros, which are apparently
	   considered "undefined" by C90 and C++98

and

	2) doesn't involve "extern" applied to a definition rather than
	   a declaration, which breaks building on some platforms (and
	   which I think is also not legal C).

Change-Id: I7eb98963a6d2e1bc9f869ebce3d7ba9228b6c9e4
Reviewed-on: https://code.wireshark.org/review/1188
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Add CRC-8 calculator for EPON

See IEEE Standard 802.3-2012 Section 5, Clause 65

Change-Id: I83d8adfd5c4fd1f263175ac726854d51419b34e0
Reviewed-on: https://code.wireshark.org/review/1187
Reviewed-by: Evan Huus <eapache@gmail.com>