Dne 13. 3. 2014 12:50, Stas Gromov napsal(a):
>
> In src/main/java/org/scribe/extractors/JsonTokenExtractor.java:
>
> > @@ -8,14 +8,20 @@
> >
> >  public class JsonTokenExtractor implements AccessTokenExtractor {
> >    private Pattern accessTokenPattern = Pattern.compile("\"access_token\"\\s*:\\s*\"(\\S*?)\"");
> > +  private Pattern idTokenPattern = Pattern.compile("\"id_token\"\\s*:\\s*\"(\\S*?)\"");
>
> JsonTokenExtractor is a common Extractor for a lot of OAuth Providers. 
> It's not nice to modify it to support non-OAuth extension of only one 
> Provider.
> What's wrong with creating subclass "GoogleApi20JsonTokenExtractor"? 
> Rename later to "OpenIDJsonTokenExtractor" may be.
> I'm planning to create maven submodules. Core module and Apis modules. 
> In that case, core module shouldn't know anything about OpenID, until 
> OpenID token in response becomes a part of the OAuth specifications.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/hhru/subscribe/pull/1/files#r10561034>.
>
I do not like new packages. It shall be standard packages like other 
additions. I rebased my repository, moved those two new classes to 
standard packages and commited them.

b3d50aba93d82dd951c1c74a2d6839f76cdf49ae
literakl at 13.3.14 22:43

*Move new classes to default packages*

Unfortunatelly I do not see them in GitHub. I will have to read git docs.

Leos