Issue #109

Fixes issue #109 where nested parentheses within the parameter signature additional traits caused a failure to correctly recognise the signature as valid due to not matching the ParameterAbbrevDefinitionRegex.
I have removed the regex in favour of manually parsing the parameter signature so as to make the code clearer and more maintainable than what the regex would have had to become in order to match nested brackets within the additional traits as well as possible additional brackets in the signature description.
I know what you mean but it is used elsewhere and I wanted
IsValidParameterSignature to have a single responsibility and not include
retrieving information so that it was correct in the context of only
needing to check the signature validity as used
in HasParameterDefinitionSignature


On 15 July 2014 09:07, Z <notifications@github.com> wrote:

> In src/ParameterDefinitonParser.h:
>
> > -                parameter.name = captureGroups[1];
> > -                TrimString(parameter.name);
> > -
> > -                // Default value
> > -                if (!captureGroups[3].empty())
> > -                    parameter.defaultValue = captureGroups[3];
> > -
> > -                // Additional Attributes
> > -                if (!captureGroups[5].empty())
> > -                    ProcessSignatureAdditionalTraits(section, cur, captureGroups[5], sourceData, result, parameter);
> > -
> > -                // Description
> > -                if (!captureGroups[7].empty())
> > -                    parameter.description = captureGroups[7];
> > +
> > +            if (IsValidParameterSignature(signature)) {
>
> Just a thought – can't this IsValidParameterSignature be used to retrieve
> the data? Since call to IsValidParameterSignature() followed by the
> complex retrieval bellow ... feels really complex ...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apiaryio/snowcrash/pull/146/files#r14921499>.
>