Fix for #170 Empty cerch file after Failed to get `https://supermarket.getchef.com/universe.json' in 15 seconds!

Agreed, however any exception here would make list nil, and may therefore lead to an invalid cerch file


Sent from my Samsung Galaxy smartphone.


-------- Original message --------
From: Seth Vargo <notifications@github.com> 
Date:2014/12/11  18:04  (GMT+00:00) 
To: berkshelf/berkshelf-api <berkshelf-api@noreply.github.com> 
Cc: Martin Walton <martin.walton@hotmail.co.uk> 
Subject: Re: [berkshelf-api] Fix for #170 Empty cerch file after Failed to get  `https://supermarket.getchef.com/universe.json' in 15 seconds! (#171) 

In lib/berkshelf/api/cache_builder/worker/supermarket.rb:

>  
> -            list
> +              list
> +            end
> +          rescue
Rescuing a blind exception seems bad to me...

—
Reply to this email directly or view it on GitHub.