Not sure this is right ? would return true if other is a super set, you should probably check the length.