Fix icon padding issue in menus

- Fixed icon padding issue in menus
(This is temporary solution)
remove unneeded String#mb_chars from SearchHelper

Test fails randomly.

<pre>
  1) Error:
SearchHelperTest#test_highlight_multibyte:
ArgumentError: invalid byte sequence in UTF-8
    app/helpers/search_helper.rb:36:in `block in highlight_tokens'
    app/helpers/search_helper.rb:26:in `each'
    app/helpers/search_helper.rb:26:in `each_with_index'
    app/helpers/search_helper.rb:26:in `highlight_tokens'
    test/unit/helpers/search_helper_test.rb:46:in `test_highlight_multibyte'
</pre>

String#mb_chars is for Ruby 1.8 compatibility.
Rails4 dropped Ruby 1.8 support.

--HG--
branch : ../sandbox/rails-4.1
extra : convert_revision : svn%3Ae93f8b46-1217-0410-a6f0-8f06a7374b81/sandbox/rails-4.1%4013414
Fix watchers-list in details pane

- fixed watchers-list in details pane
- changed color of the remove icon from black to red
- added global color variables
Merge pull request #1953 from marutosi/finn/mb_chars

remove unneeded String#mb_chars from SearchHelper
adds scope for retreiving system shared versions
allows version selection for global filtering
renders version name depending on context

Versions being in the same project as the project the view is rendered
for get simply the name as their name attribute. Versions being in a
  different project as the project the view is rendered for get the
  project name prepended to the name as their name attribute. The later
  is also true for when no project is provided as the context.
Merge pull request #1928 from opf/fix/global_version_filter

Fix/global version filter
Living Style Guide: Document OpenProject colors

[ci skip]

Signed-off-by: Alex Coles <alex@alexbcoles.com>
Merge pull request #1954 from opf/fix/watcher-overlapping-in-details-pane

Fix watchers-list in details pane
types controller is admin only now
Merge pull request #1945 from opf/fix/icon-padding-issue

Fix icon padding issue in menus
Merge pull request #1957 from opf/fix/types_no_longer_accessible_by_non_admins

types controller is admin only now
#after_login can now receive a context variable (usually the controller)
make Hound happy (and Markus)
give the context a more useful default value