yeah that looks a bit strange and technically is a circular dependency but
that's how it's been configured. I tried putting the MTCPMR first in the
list, and that worked sort of, but would have not been able to override the
default inputType with an explicit option.


On Fri, May 2, 2014 at 3:34 PM, Ilayaperumal Gopinathan <
notifications@github.com> wrote:

> In
> spring-xd-module/src/main/java/org/springframework/xd/module/options/FlattenedCompositeModuleOptionsMetadata.java:
>
> >  		for (final ModuleOptionsMetadata delegate : delegates) {
> >  			Set<String> optionNames = new HashSet<String>();
> >  			momToSupportedOptions.put(delegate, optionNames);
> >  			for (ModuleOption option : delegate) {
> > -				if (options.put(option.getName(), option) != null) {
> > -					reportOptionCollision(delegates, option.getName());
> > +				if (options.get(option.getName()) != null) {
>
> Just curious, Is the delegate for the actual module's
> moduleOptionsMetadata always the first in the list before the
> ModuleTypeConversionPluginMetadataResolver's Input/Output OptionsMetadata?
> Like the way they are defined here?:
>
> <bean id="moduleOptionsMetadataResolver" class="org.springframework.xd.module.options.EnvironmentAwareModuleOptionsMetadataResolver">
>         <property name="delegate">
>             <bean class="org.springframework.xd.module.options.DelegatingModuleOptionsMetadataResolver">
>                 <property name="delegates">
>                     <list>
>                         <bean class="org.springframework.xd.module.options.DefaultModuleOptionsMetadataResolver">
>                             <property name="compositeResolver" ref="moduleOptionsMetadataResolver" />
>                         </bean>
>                         <bean class="org.springframework.xd.dirt.plugins.stream.ModuleTypeConversionPluginMetadataResolver" />
>                         <bean class="org.springframework.xd.dirt.plugins.job.JobPluginMetadataResolver" />
>                     </list>
>                 </property>
>             </bean>
>         </property>
>     </bean>
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/spring-projects/spring-xd/pull/812/files#r12244305>
> .
>