(PUP-2909) enabling Lint/AssignmentInCondition in pops

Use `||` instead of `or`.<br>Redundant curly braces around a hash parameter.<br>Use the new Ruby 1.9 hash syntax.<br>Line is too long. [92/80]<br>Space inside { missing.<br>Space inside } missing.