So many clang analzyer problems arise from expecting ERROR_NO to bail
process_command doesn't check argument existance

Should process_command not get an argument, we get NULL deference errors
inside process_reset, process_dump, process_trace, and process_set.

Caught by clang-analyzer.
Defencive check for key when doing AKAv1-MD5

It is possible to do AKAv1-MD5 and get a null dereference if aka_K
isn't provided. One of the auth tests triggered this defect even though
it was doing MD5 (static analyzer won't do the parsing of the algorithm
field).

Cause by clang-analyzer.
Drop dead assignments/increments/initialization

Caught by clang-analyzer.
Use-after-free if sendCmdBuffer fails

The call class deletes itself on failure so we really can't continue
with the method. Needs to abort immediately. (Seriously, the class is
calling delete this? That's just asking for pain).

Caught by clang-analyzer.
You cannot call computeStat after abortCall.

call::abortCall also does delete this. Which means you can't call
call::computeStat safely after the fact. Another use-after-free bug.

Caught by clang-analyzer.
Correct the return from connect_to_peer

connect_to_peer is returning stack-allocated memory. The stack allocated
T_peer_infos structure technically means a copy from the iterator,
meaning that we can't really return the address of peer_socket safely.

Caught by clang-analyzer.
Fix garbage/undefined load on E_Message_Server_IP

SOCK_ADDR_SIZE can't be used here because server_sockaddr. The
structure is uninitialized so we can't look up the ss_family.

It's just fine calling getsockname with sizeof the full
sockaddr_storage structure, the macro is overkill. I wonder if that's
the case in other places.

Caught by clang-analyzer.
Fix potential memory leak after second strtok

Memory is allocated before we know if anything is there to copy into
it. Flat out rewritten.

Caught by clang-analyzer.
Fix potential memory leak when HAVE_PCAP_NEXT_EX isn't defined

We malloc pkthdr, we must free it too.

Caught by clang-analyzer.
Free the existing M_regularExpression if its already set

Potential memory leak. Passing P_value into regcomp to placate the
static analyzer.

Caught by clang-analyzer.
Bail out if dest is NULL

The currently protective check isn't sufficient. Bail out to avoid
invalid memory access.
Check if call_socket is NULL before dereferencing

Static analyzer is finding that its possible to get a NULL call_socket
here, so lets be defencive and check for it.

Caught by clang-analyzer.
Check if play_args is NULL before dereferencing

Caught by clang-analyzer.
Fix NULL dereference in xp_open_element

Bail outright if xp_find_start_tag_end fails. The if (ptr) check here
isn't sufficient because later on we'll hit ptr++.

Caught by clang-analyzer.
Merge pull request #115 from vodik/defects

Fixes for various defects detected by clang-analyzer