ls looking good, still need to run test cases