docs(menus): improve docs for menu item factory

Clarifies that the 2nd argument for elgg_register_menu_item() is used
as the arguments for ElggMenuItem::factory() and the options PHPdocs
are moved to factory().
Merge pull request #7348 from mrclay/menuitem_docs

docs(menus): improve docs for menu item factory
fix(uservalidationbyemail): makes emailsent page public

Marks uservalidationbyemail/emailsent as a public page in walled garden to
ensure that newly registered users receive a understandabe comfirmation page.

Fixes #7334
Merge pull request #7358 from stianlik/uservalidationbyemail

fix(uservalidationbyemail): makes emailsent page public
chore(style): adds components and tests for some whitespace issues
chore(cleanup): whitespace normalization done by script