Correct TarSum benchmarks: 9kTar and 9kTarGzip

These two cases did not actually read the same content with each iteration
of the benchmark. After the first read, the buffer was consumed. This patch
corrects this by using a bytes.Reader and seeking to the beginning of the
buffer at the beginning of each iteration.

Unfortunately, this benchmark was not actually as fast as we believed. But
the new results do bring its results closer to those of the other benchmarks.

Docker-DCO-1.1-Signed-off-by: Josh Hawn <josh.hawn@docker.com> (github: jlhawn)
Correctly close generated benchmark archives

Another update to TarSum tests, this patch fixes an issue where
the benchmarks were generating archives incorrectly by not closing
the tarWriter.

Docker-DCO-1.1-Signed-off-by: Josh Hawn <josh.hawn@docker.com> (github: jlhawn)
Fix interactive exec over TLS

The code no longer assumes a net.TCPConn underlying the HTTP connection
in order to close attached streams.

Signed-off-by: Arnaud Porterie <arnaud.porterie@docker.com>
Return docker's root dir in docker -D info

This adds the docker daemon's root directory to docker info when running
in debug mode.  This allows the user to view the root directory where
docker is writing and storing state.

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
Merge pull request #9479 from jlhawn/tarsum_test_fix

Correct TarSum benchmarks: 9kTar and 9kTarGzip
Removed race condition
If two interrupts were fired really quickly interruptCount could have been incremented twice before the LoadUint32 making cleanup not being called at all.

Signed-off-by: Erik Dubbelboer <erik@dubbelboer.com>
Merge pull request #9543 from ErikDubbelboer/racefix

Removed race condition
Merge pull request #9497 from icecrime/86580-tls_interactive_exec

Fix interactive exec over TLS
Merge pull request #9489 from crosbymichael/info-root

Return docker's root dir in docker -D info
Merge remote-tracking branch 'origin/master' into bump_v1.4.0

* origin/master: (529 commits)
  Removed race condition If two interrupts were fired really quickly interruptCount could have been incremented twice before the LoadUint32 making cleanup not being called at all.
  Return docker's root dir in docker -D info
  I was talking to someone whom i listen to, and she noted that our docs don't mention the license
  Show image of the Build trigger screen, and add a little search engine fodder for it.
  Add some extra details to webhook docs
  this v spacing irritated me while i was reading
  Auto-update documentation from the output of the cli.
  Use consistent ApplyLayer in overlayfs
  Update Amazon EC2 Docker installation instructions
  Fixing docs formatting for the forcerm flag on docker build
  Fix interactive exec over TLS
  Correctly close generated benchmark archives
  Something changed, broke the docs release script, and it seems that --exclude still doesn't work, so I'm removing it
  Fix output format where no variable specified in mount pkg
  Run 'go vet' on integration-cli.
  Remove unnessary abstraction deepEqual
  Note that using -lxc-conf to change things Docker manages has pitfalls
  Remove unnecessary abstraction nLines
  cleanup: remove startCommand function, only used once, and unecessary abstraction.
  Be consistent about libtrust import path.
  ...

Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <jess@docker.com> (github: jfrazelle)
Bump version to

Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <jess@docker.com> (github: jfrazelle)