Web Inspector: Processing Instruction Nodes appear poorly in DOM Tree
https://bugs.webkit.org/show_bug.cgi?id=137681

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-10-14
Reviewed by Timothy Hatcher.

Source/WebCore:

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForNode):
Include the nodeName, localName, and nodeValue (string data)
properties for processing instruction nodes.

Source/WebInspectorUI:

Handle processing instruction node types in more places. The
backend sends the contents as a pure string, not as attribute
pairs, so just include the string in the UI.

* UserInterface/Models/DOMSearchMatchObject.js:
(WebInspector.DOMSearchMatchObject.prototype._generateClassName):
(WebInspector.DOMSearchMatchObject.titleForDOMNode):
* UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype._nodeTitleInfo):
Display the value in the UI.

* UserInterface/Views/DOMTreeElementPathComponent.js:
(WebInspector.DOMTreeElementPathComponent):
Include an icon like DOCTYPE.

* UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
(.syntax-highlighted .html-processing-instruction):
Style gray like a DOCTYPE.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Update ViewportConfiguration whenever its size attributes change
https://bugs.webkit.org/show_bug.cgi?id=137682
rdar://problem/18643655

Reviewed by Benjamin Poulain.

* page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::setMinimumLayoutSize):
(WebCore::ViewportConfiguration::setMinimumLayoutSizeForMinimalUI):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Addressing post-review comment.
https://bugs.webkit.org/show_bug.cgi?id=137550

Unreviewed.

* WebView/WebHTMLView.mm:
(fontNameForDescription):
(-[WebHTMLView _addToStyle:fontA:fontB:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Adding myself to the watchlist to CachedFont

Unreviewed.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove unnecessary logging from SimpleFontData
https://bugs.webkit.org/show_bug.cgi?id=137699

Reviewed by Andreas Kling.

Because of web fonts, fonts that don't have a glyph page 0 are common and expected. Printing out a
message is not helpful, especially if you're not dealing with a font-related piece of WebKit.

No new tests because there is no behavior change.

* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::platformGlyphInit):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Windows] Add some logging to debug random crashing when running layout tests on Windows.

* WebActionPropertyBag.cpp:
(WebActionPropertyBag::Read):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[cmake] Fix the make build after r174683
https://bugs.webkit.org/show_bug.cgi?id=137703

Reviewed by Martin Robinson.

* Scripts/webkitdirs.pm:
(buildCMakeGeneratedProject):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Removes references to LLVMJIT which is no longer part of LLVM
https://bugs.webkit.org/show_bug.cgi?id=137708

Reviewed by Filip Pizlo.

* Configurations/LLVMForJSC.xcconfig: removed -lLLVMJIT
* llvm/LLVMAPIFunctions.h: removed LinkInJIT


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Mac] Avoid unnecessary dictionary lookup in ImageSource::isSizeAvailable()
https://bugs.webkit.org/show_bug.cgi?id=137701

Reviewed by Simon Fraser.

The CG implementation of ImageSource::isSizeAvailable() was looking up
both the width and the height keys in the dictionary before determining
if the size is available. We can abort early and return false if the
first key (the width) is missing, thus avoiding an extra dictionary
lookup in this case.

This is a small win but ImageSource::isSizeAvailable() is called quite
frequently during page loads

No new tests, no behavior change.

* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::isSizeAvailable):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: paint flashing mode should be disabled when remote inspecting legacy iOS versions
https://bugs.webkit.org/show_bug.cgi?id=137575

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-10-14
Reviewed by Simon Fraser.

Remove setShowPaintRects from the legacy iOS protocol definitions.
The methods were unimplemented by the backends, so they should
not advertise supporting it.

* UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js:
* UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
* UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js:
* Versions/Inspector-iOS-6.0.json:
* Versions/Inspector-iOS-7.0.json:
* Versions/InspectorWeb-iOS-8.0.json:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION(r174567): [GTK] Layout Tests platform/gtk/accessibility/aria-table-hierarchy.html and platform/gtk/accessibility/table-hierarchy.html fail
https://bugs.webkit.org/show_bug.cgi?id=137697

These tests were overlooked when updating tests to reflect the correct
mapping for ColumnHeaderRole and RowHeaderRole in ATK.

Reviewed by Chris Fleizach.

* platform/gtk/TestExpectations: Remove two failing tests.
* platform/gtk/accessibility/aria-table-hierarchy-expected.txt: Updated expectations.
* platform/gtk/accessibility/aria-table-hierarchy.html: Updated in-test shouldBe values for headers.
* platform/gtk/accessibility/table-hierarchy-expected.txt: Updated expectations.
* platform/gtk/accessibility/table-hierarchy.html: Updated in-test shouldBe values for headers.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@174697 268f45cc-cd09-0410-ab3c-d52691b4dbfc