Yep, new code looks good.  Thanks.


On Sun, Apr 6, 2014 at 7:46 PM, Matt Rasmussen <notifications@github.com>wrote:

> In compbio/coal.py:
>
> >      for leaf in tree.leaves():
> > -        tree.rename(leaf.name, namefunc(recon[leaf].name))
> > +        newname = namefunc(recon[leaf].name)
> > +        if newname in tree.nodes:   # create unique name
> > +            if newname not in name_counts: name_counts[newname] = 0
>
> Actually looking at this further this extra code shouldn't be needed.
> namefunc should be responsible for assigning unique names, see:
> https://github.com/wutron/compbio/blob/yjw-libs/compbio/coal.py#L896-L902
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/wutron/compbio/pull/2/files#r11328738>
> .
>